sshfs icon indicating copy to clipboard operation
sshfs copied to clipboard

allow passing kwargs to sftp client

Open ttomasz opened this issue 1 year ago • 7 comments

Fixes #39

ttomasz avatar Feb 17 '24 13:02 ttomasz

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.07%. Comparing base (64cc6ef) to head (59a8fe7). Report is 1 commits behind head on main.

:exclamation: Current head 59a8fe7 differs from pull request most recent head b971999

Please upload reports for the commit b971999 to get more accurate results.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
- Coverage   94.19%   94.07%   -0.13%     
==========================================
  Files          13       13              
  Lines         723      742      +19     
==========================================
+ Hits          681      698      +17     
- Misses         42       44       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 17 '24 14:02 codecov-commenter

@efiop Would you mind reviewing this PR?

ttomasz avatar Mar 11 '24 23:03 ttomasz

Hey, @ttomasz , thanks for the PR! Please see some suggestions above.

efiop avatar Mar 18 '24 01:03 efiop

@ttomasz a gentle reminder :) or can we close this PR?

shcheklein avatar Jun 01 '24 00:06 shcheklein

Sorry, was quite busy past few months 😅 I should be able to finish this up in June.

ttomasz avatar Jun 01 '24 17:06 ttomasz

Changed popping kwargs to separate parameter for stuff to pass to underlying library.

ttomasz avatar Jun 16 '24 17:06 ttomasz

Sorry for the mess with the commits. Do you want me to revert client_args/connect_args to being kwargs instead of parameter? Or is the current state ok?

ttomasz avatar Jun 16 '24 18:06 ttomasz