sshfs icon indicating copy to clipboard operation
sshfs copied to clipboard

synchronous `rmdir()` fails silently

Open isoflavone-r opened this issue 1 year ago • 1 comments

Hello.

Trying to remove directories using SSHFileSystem via rmdir fails silently.

Appears to be missing the synchronous wrapper for _rmdir. i.e. the equivalent of: mkdir = sync_wrapper(_mkdir) and thus ends up all the way in AbstractFileSystem.rmdir which is implemented as pass # not necessary to implement, may not have directories.

A local test of adding the sync_wrapper works ok so far.

isoflavone-r avatar Oct 14 '23 00:10 isoflavone-r

Hey @isoflavone-r , thanks for the report! Makes sense. Would you be interested in contributing a fix? If so, please feel free to submit a PR.

efiop avatar Oct 14 '23 02:10 efiop