s3fs icon indicating copy to clipboard operation
s3fs copied to clipboard
verified publisher icon fsspec

Use the Async DNS resolver where possible. Closes #543.

Open orf opened this issue 4 years ago • 4 comments

Needs https://github.com/aio-libs/aiobotocore/pull/906 first. I'll add tests once that's merged.

orf avatar Dec 10 '21 15:12 orf

Why is this not default? :)

martindurant avatar Dec 10 '21 15:12 martindurant

It needs an extra package installed I guess. I'm not really sure

orf avatar Dec 10 '21 15:12 orf

It needs an extra package installed I guess. I'm not really sure

If this is a third party dependency, wouldn't it make sense to ask clients to pass it instead of embedding it directly into s3fs? AFAIK you should be able to customize config_kwargs.

isidentical avatar Dec 12 '21 07:12 isidentical

Sure, but if you look at #543 there is a very annoying case where this is basically required.

If you use s3fs with the logging module then during interpreter shutdown it's more than likely that the files just won't be closed correctly.

So I feel like the aiodns resolver should be the default if it's available.

orf avatar Dec 12 '21 15:12 orf