adlfs icon indicating copy to clipboard operation
adlfs copied to clipboard

Don't drop paths containts globs

Open Antaxify opened this issue 2 years ago • 5 comments

This PR contains the following changes:

  • fixed the list comprehension in _expand_path to not drop glob paths (foo/bar/*)
  • fixed _expand_path when called with a glob path and recursive=True
  • fixed _glob_find when called with a glob path
  • added a test to map the current behavior of expand_path (recursive=True)
  • fix _put_file when called with a path that is a directory

Please let me know what you think about these changes.

I noticed that _glob_find and _find are not consistent when returning directory paths. _find returns trailing slashes while _glob_find does not. Is that intended?

Also in the current implementation _expand_path includes the root directory for non-glob paths, while _glob_find does not. What is the desired behavior here?

About tests:

  • test_url failed for me with a 403 before my changes - did not look into that
  • I don't know why the CI tests are failing - I guess this is a general issue?

Antaxify avatar Apr 05 '22 15:04 Antaxify

Thanks for digging in here.

CI tests run against Azurite, which Microsoft updated 6 weeks ago. I'll dig into this failure mode, then I'll circle back to the question of other topics.

hayesgb avatar Apr 09 '22 13:04 hayesgb

Any update on this?

Antaxify avatar Apr 28 '22 09:04 Antaxify

@hayesgb did you find time to look into this?

Antaxify avatar May 18 '22 06:05 Antaxify

Anything I can do to get this merged?

Antaxify avatar Jul 07 '22 11:07 Antaxify

Any update or progress on this?

hfurkanvural avatar Jul 21 '22 12:07 hfurkanvural