adlfs
adlfs copied to clipboard
Don't drop paths containts globs
This PR contains the following changes:
- fixed the list comprehension in _expand_path to not drop glob paths (foo/bar/*)
- fixed _expand_path when called with a glob path and recursive=True
- fixed _glob_find when called with a glob path
- added a test to map the current behavior of expand_path (recursive=True)
- fix _put_file when called with a path that is a directory
Please let me know what you think about these changes.
I noticed that _glob_find and _find are not consistent when returning directory paths. _find returns trailing slashes while _glob_find does not. Is that intended?
Also in the current implementation _expand_path includes the root directory for non-glob paths, while _glob_find does not. What is the desired behavior here?
About tests:
- test_url failed for me with a 403 before my changes - did not look into that
- I don't know why the CI tests are failing - I guess this is a general issue?
Thanks for digging in here.
CI tests run against Azurite, which Microsoft updated 6 weeks ago. I'll dig into this failure mode, then I'll circle back to the question of other topics.
Any update on this?
@hayesgb did you find time to look into this?
Anything I can do to get this merged?
Any update or progress on this?