SQLProvider icon indicating copy to clipboard operation
SQLProvider copied to clipboard

Add user defined function call support for MSSQL

Open MMagueta opened this issue 2 years ago • 3 comments
trafficstars

Proposed Changes

WIP

Types of changes

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [X] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • [ ] Build and tests pass locally
  • [ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • [ ] I have added necessary documentation (if appropriate)

Further comments

WIP

MMagueta avatar Jan 08 '23 17:01 MMagueta

Status:

  • [X] Parse the XML for a scalar function and inline table functions
  • [X] Add callable reference on F#
  • [ ] Check parameters for inlined tables and other not so primitive types, such as XML
  • [ ] Tests

MMagueta avatar Jan 08 '23 17:01 MMagueta

@JordanMarr I am facing a problem that you might have a field view wider than I do. XML fields are simply not being translated to XElement. A procedure/function/UDDT that has an XML type exposed simply does not get designed, not resulting in an overall failure, the rest continues to work just fine. I did confirm that System.Xml.Linq.XElement is on the map for the TSQL correspondence. Any ideas of how to assess this?

MMagueta avatar Jan 16 '23 00:01 MMagueta

Is this question related to the SSDT parser? If so, it might be helpful if you added the sqlproj to the test sln with a broken test to highlight the issue.

JordanMarr avatar Jan 16 '23 01:01 JordanMarr