ProjectScaffold icon indicating copy to clipboard operation
ProjectScaffold copied to clipboard

Create github releases

Open forki opened this issue 10 years ago • 16 comments

See https://github.com/fsprojects/Paket/commit/68704bcbb11cece54d363b3ee2099d5d6e2a3409 and https://github.com/fsprojects/Paket/commit/d33887d0292ef6487f2bcb74b0e6e81a39d6f496#diff-6074983490330a0aac1bd23c958232d7R282

It would not be that hard. If we want to do it.

forki avatar Sep 19 '14 09:09 forki

Hmm... I'm torn. Part of me likes the idea; I think it'd simplify certain use cases. But part of me never intended for the scaffold to require versioning. It was intended to be a learning tool (as much as it is a timesaver) for folks. So I guess I could see it argues either way.

pblasucci avatar Sep 19 '14 15:09 pblasucci

I thought the idea was to provide a opionated way to build (F#) projects?!

forki avatar Sep 19 '14 15:09 forki

I agree with @forki that the project has now really become "the opinionated template for F# community projects". Not sure you intended that @pblasucci but it's a great thing :)

I'm not sure about GitHub releases, was looking at it but need to dig more

dsyme avatar Sep 19 '14 15:09 dsyme

Ok regarding github.com releases:

  • it's always available (at least compared to nuget.org which goes down regularly)
  • you can download by clicking on website or using simple https client

forki avatar Sep 19 '14 15:09 forki

Okay. I've thought about it some more... :-) Let's do it. Having releases will avoid confusion in case the scaffold "changes opinions".

Of course, I won't really have time for this until next week.

pblasucci avatar Sep 19 '14 15:09 pblasucci

After reading your reply. I don't want releases for the scaffolding project. I want to scaffold code which allows the generated projects to push to github releases. On Sep 19, 2014 5:55 PM, "Paulmichael Blasucci" [email protected] wrote:

Okay. I've thought about it some more... :-) Let's do it. Having releases will avoid confusion in case the scaffold "changes opinions".

— Reply to this email directly or view it on GitHub https://github.com/fsprojects/ProjectScaffold/issues/82#issuecomment-56196317 .

forki avatar Sep 19 '14 15:09 forki

Whoops! I totally misunderstood your comment. Sorry... I'm trying to juggle too many things at once.

Now that I understand what you meant, I think it's fine to have multiple deployment targets (nuget, github, etc). Let's just make sure the number of choices stays manageable and is explained clearly in the docs.

pblasucci avatar Sep 19 '14 16:09 pblasucci

Let's see how it works in Paket and then I will send a PR. Just wanted to discuss this idea.

2014-09-19 18:02 GMT+02:00 Paulmichael Blasucci [email protected]:

Whoops! I totally misunderstood your comment. Sorry... I'm trying to juggle too many things at once.

Now that I understand what you meant, I think it's fine to have multiple deployment targets (nuget, github, etc). Let's just make sure the number of choices stays manageable and is explained clearly in the docs.

— Reply to this email directly or view it on GitHub https://github.com/fsprojects/ProjectScaffold/issues/82#issuecomment-56197378 .

forki avatar Sep 19 '14 16:09 forki

Hi @forki, could you add the "GitHub releases" to the most important F# community projects first, e.g. FSharp.Data and FSharp.Compiler.Service and maybe a few others? Just so we get a feel for what it means and start to spread it through the community, (I assume nuget package releases will still be used as well.)

dsyme avatar Sep 19 '14 16:09 dsyme

will do. At the moment I try to dogfood it in Github's octokit.

2014-09-19 18:37 GMT+02:00 Don Syme [email protected]:

Hi @forki https://github.com/forki, could you add the "GitHub releases" to the most important F# community projects first, e.g. FSharp.Data and FSharp.Compiler.Service and maybe a few others? Just so we get a feel for what it means and start to spread it through the community, (I assume nuget package releases will still be used as well.)

— Reply to this email directly or view it on GitHub https://github.com/fsprojects/ProjectScaffold/issues/82#issuecomment-56201868 .

forki avatar Sep 19 '14 16:09 forki

actually after thinking about it I'm not sure if libs should go to github releases. Maybe it's more for apps. Still thinking about it.

forki avatar Sep 19 '14 17:09 forki

In some of my projects (F# Formatting, RProvider?, Deedle?) we actually push release binaries to release branch so that the binaries can be easily downloaded somewhere (which is indeed totally wrong). If GitHub releases provide an easy to use replacement for this then I really like the idea!

If I can get a free PR from @forki for F# formatting, that would be awesome :-)

tpetricek avatar Sep 19 '14 17:09 tpetricek

git

forki avatar Sep 19 '14 17:09 forki

let's start with https://github.com/tpetricek/FSharp.Formatting/pull/197

afterwards I will add github releases

forki avatar Sep 19 '14 17:09 forki

@forki Would you mind to send a PR adding GitHub releases to VFPT :-)? Whenever we update a new version to VS Gallery, the old binaries disappeared. It's great to be able to use GitHub releases for archiving old binaries.

dungpa avatar Sep 20 '14 10:09 dungpa

lol.

Maybe after we get https://github.com/fsprojects/VisualFSharpPowerTools/pull/713 working ;-)

2014-09-20 12:40 GMT+02:00 Anh-Dung Phan [email protected]:

@forki https://github.com/forki Would you mind to send a PR adding GitHub releases to VFPT :-)? Whenever we update a new version to VS Gallery, the old binaries disappeared. It's great to be able to use GitHub releases for archiving old binaries.

— Reply to this email directly or view it on GitHub https://github.com/fsprojects/ProjectScaffold/issues/82#issuecomment-56264288 .

forki avatar Sep 20 '14 10:09 forki