Stack overflow exception when generating documentation

[Vidarls]

Getting stack overflows today when generating documentation.

Seems it was introduces when you moved to using FSharp.Core as a nuget package.

Clean checkout for 2a87478f5121930f4fec9b9ca1846fc117a5058e seems to work. Clean checkout for 83f0514da822648ad5b1a5efdad3be1e2d21c086 seems to create stack overflow.

Will investigate further.

[Vidarls]

[forki]

https://github.com/fsprojects/FSharpx.Reflection/issues/1 sems I'm not the only one.

[Vidarls]

Confirmed, just manually reverted the changes from 83f0514da822648ad5b1a5efdad3be1e2d21c086 and voila, no more stackoverflow exceptions

[Vidarls]

That is current master minus changes from 83f0514da822648ad5b1a5efdad3be1e2d21c086 is ok,

[Vidarls]

Will do a pull req

[Vidarls]

TIL: git revert is very useful :smile:

[forki]

But removing FSharp.Core package will create other issue.

If FCS creates a StackOverflow on FSharp.Core nuget package then this needs to be investigated. /cc @dsyme @7sharp9 @tpetricek @dungpa

[Vidarls]

Better with some corner case issues in the master branch than outright stackoverflows? We can go back ot using the nuget package once FCS have sorted the problem

[forki]

I agree and merged it as a temporary fix.