Paket icon indicating copy to clipboard operation
Paket copied to clipboard

Document that Paket.Restore.targets should not be gitignored

Open ploeh opened this issue 8 years ago • 20 comments

Sorry if this is a FAQ, but I've tried to search, and couldn't find an answer.

When I run the build script for FsCheck, it leaves behind a Paket.Restore.targets file. It didn't use to do that earlier, but I suppose it's a new feature of Paket.

Should this file be checked into source control, or should it be ignored (added to .gitignore)?

ploeh avatar Oct 12 '17 09:10 ploeh

Good question we currently seem to add the file to source control, but for technical reasons.

matthid avatar Oct 12 '17 09:10 matthid

with latest paket you can gitignore it

forki avatar Oct 12 '17 09:10 forki

bump - when is paket supposed to restore this file? I gitignored it and after git clean -fxd I'm no longer able to build cause of .paket\Paket.Restore.targets" was not found. paket restore does not download the targets file, how is it supposed to be downloaded?

theimowski avatar Oct 21 '17 09:10 theimowski

Actually latest paket should do it. But only paket.restore.targets not paket.targets if you are using that.

Am 21.10.2017 11:38 schrieb "Tomasz Heimowski" [email protected]:

bump - when is paket supposed to restore this file? I gitignored it and after git clean -fxd I'm no longer able to build cause of .paket\Paket.Restore.targets" was not found. paket restore does not download the targets file, how is it supposed to be downloaded?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/fsprojects/Paket/issues/2840#issuecomment-338378798, or mute the thread https://github.com/notifications/unsubscribe-auth/AADgNI_mlxX_17rFGNsAO75RjaDXVwUnks5subukgaJpZM4P2ufz .

forki avatar Oct 21 '17 09:10 forki

restore command? doesn't work for me:

image

theimowski avatar Oct 21 '17 10:10 theimowski

Do you have have a .NET sdk project in there?

Am 21.10.2017 12:03 schrieb "Tomasz Heimowski" [email protected]:

restore command? doesn't work for me:

[image: image] https://user-images.githubusercontent.com/5909015/31850732-d22004e4-b657-11e7-9e64-4ce0e315aa9a.png

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/fsprojects/Paket/issues/2840#issuecomment-338380226, or mute the thread https://github.com/notifications/unsubscribe-auth/AADgNOyW-xLXin551Doq9CmlAq35byU3ks5sucFvgaJpZM4P2ufz .

forki avatar Oct 21 '17 10:10 forki

yep, 2 .NET sdk projects, like in SAFE-bookstore: image

theimowski avatar Oct 21 '17 10:10 theimowski

Mhm then it's considered a bug. Can you please upload that zip

Am 21.10.2017 12:14 schrieb "Tomasz Heimowski" [email protected]:

yep, 2 .NET sdk projects, like in SAFE-bookstore: [image: image] https://user-images.githubusercontent.com/5909015/31850803-5395a154-b659-11e7-8210-f2decedf8056.png

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/fsprojects/Paket/issues/2840#issuecomment-338380886, or mute the thread https://github.com/notifications/unsubscribe-auth/AADgNJOgYRbjzaAWlM8LPa5ptXZTTqFdks5sucPwgaJpZM4P2ufz .

forki avatar Oct 21 '17 10:10 forki

Just one last thing. Make sure to nuke Paket-files folder before restore. Maybe it decided that everything was up to date

Am 21.10.2017 12:15 schrieb "Steffen Forkmann" [email protected]:

Mhm then it's considered a bug. Can you please upload that zip

Am 21.10.2017 12:14 schrieb "Tomasz Heimowski" [email protected]:

yep, 2 .NET sdk projects, like in SAFE-bookstore: [image: image] https://user-images.githubusercontent.com/5909015/31850803-5395a154-b659-11e7-8210-f2decedf8056.png

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/fsprojects/Paket/issues/2840#issuecomment-338380886, or mute the thread https://github.com/notifications/unsubscribe-auth/AADgNJOgYRbjzaAWlM8LPa5ptXZTTqFdks5sucPwgaJpZM4P2ufz .

forki avatar Oct 21 '17 10:10 forki

That's right, removing paket-files did the job. Must have been that I didn't clean all ignored files before.. Thanks @forki !

theimowski avatar Oct 21 '17 10:10 theimowski

I thought we write “already up to date” in that case?

matthid avatar Oct 21 '17 10:10 matthid

What's the current recommendation for the file? Asking because of https://github.com/SAFE-Stack/SAFE-template/issues/7 - is it recommended to have the file in git only if you use VS 15.5 auto restore?

theimowski avatar Nov 08 '17 07:11 theimowski

Better commit it for proper VS support

Am 08.11.2017 08:47 schrieb "Tomasz Heimowski" [email protected]:

What's the current recommendation for the file? Asking because of SAFE-Stack/SAFE-template#7 https://github.com/SAFE-Stack/SAFE-template/issues/7 - is it recommended to have the file in git only if you use VS 15.5 auto restore?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fsprojects/Paket/issues/2840#issuecomment-342736922, or mute the thread https://github.com/notifications/unsubscribe-auth/AADgNGpIxO-IOzPKNRfvRfY6Mr3Ahmfyks5s0VyUgaJpZM4P2ufz .

forki avatar Nov 08 '17 07:11 forki

@forki can information about Paket.Restore.Targets be posted in the docs?

Paqi avatar Jun 07 '18 19:06 Paqi

yes of course - just need a PR to the docs and I can release it

Am Do., 7. Juni 2018 um 21:17 Uhr schrieb rabrahamOpti < [email protected]>:

@forki https://github.com/forki can information about Paket.Restore.Targets be posted in the docs https://fsprojects.github.io/Paket/?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fsprojects/Paket/issues/2840#issuecomment-395534244, or mute the thread https://github.com/notifications/unsubscribe-auth/AADgNCGYvbQIdKjbHQrh8S3iNxbhF-puks5t6Xw8gaJpZM4P2ufz .

forki avatar Jun 17 '18 08:06 forki

I don't feel I understand Paket.Restore.Targets to write up documentation on it, that's why I need the documentation :p

On Sun, Jun 17, 2018 at 4:42 AM, Steffen Forkmann [email protected] wrote:

yes of course - just need a PR to the docs and I can release it

Am Do., 7. Juni 2018 um 21:17 Uhr schrieb rabrahamOpti < [email protected]>:

@forki https://github.com/forki can information about Paket.Restore.Targets be posted in the docs https://fsprojects.github.io/Paket/?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://github.com/fsprojects/Paket/issues/2840#issuecomment-395534244 , or mute the thread <https://github.com/notifications/unsubscribe-auth/ AADgNCGYvbQIdKjbHQrh8S3iNxbhF-puks5t6Xw8gaJpZM4P2ufz> .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/fsprojects/Paket/issues/2840#issuecomment-397863920, or mute the thread https://github.com/notifications/unsubscribe-auth/Aa_5xwp2LQu0vhp0GeDPpfIcj2TfQDgqks5t9hZ2gaJpZM4P2ufz .

--

Paqi avatar Jun 18 '18 12:06 Paqi

Hey! Are there any updates on this? Is it recommended to ignore this or not?

mmalvik avatar May 02 '19 09:05 mmalvik

I personally would not gitignore the targets

mmalvik [email protected] schrieb am Do., 2. Mai 2019, 11:22:

Hey! Are there any updates on this? Is it recommended to ignore this or not?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fsprojects/Paket/issues/2840#issuecomment-488607369, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAOANGSSTHPJDTCV35BWEDPTKXGNANCNFSM4D6247ZQ .

forki avatar May 02 '19 10:05 forki

@forki any chance your team might consider contributing to github/gitignore to give us some quick insight as these entries change?

I'm seeing only an entry for VisualStudio but perhaps this is outdated?

kevingentile avatar Jan 08 '21 14:01 kevingentile

@kevingentile That matches the entries in the file created by dotnet new gitignore so it's probably okay.

jcmrva avatar Jun 26 '22 23:06 jcmrva