IfSharp icon indicating copy to clipboard operation
IfSharp copied to clipboard

Docker image is not updated

Open IvanAntipov opened this issue 6 years ago • 5 comments

Description

Docker image of IfSharp

https://hub.docker.com/r/fsprojects/ifsharp

Updated a year ago

Could you update this image, please.

IvanAntipov avatar Mar 16 '20 08:03 IvanAntipov

Sounds good, if someone wants to update the Docker image that's most welcome.

cgravill avatar Jun 04 '20 09:06 cgravill

I've spent a few hours trying to get the Docker image to build locally with no luck. I won't detail the errors because it's just been a game a wack-a-mole. Perhaps someone more knowledgeable with this project could audit the Dockerfile build and get it back into shape, it seems to have suffered from general code rot (docker builds are not always as reproducible as you might hope, breaking changes to externally pulled dependencies can creep in).

stephen-swensen avatar Jun 04 '20 14:06 stephen-swensen

^ sorry if the above sounded rude - I didn't mean it to be :)

stephen-swensen avatar Jun 05 '20 03:06 stephen-swensen

No problem @stephen-swensen and thanks for giving a go. There have been occasional contributions to the Docker image but it's not heavily used, and I personally don't use it at all, so getting out sync with upstream dependencies makes sense. Fixes for this would be welcome from anyone who can manage it!

cgravill avatar Jun 05 '20 14:06 cgravill

I made a version which builds for netcore, though I didn't update the mono one.

https://github.com/jhgoodwin/IfSharp/tree/features/add_netcore_dockerfile

The intellisense is broken in mine, which I think is due to 0 opened comms messages in the /notebooks/shell.log

I built it like this:

docker build -f netcore.Dockerfile -t jhgoodwin/ifsharp:dev .

Note my version uses the current source to build instead of using git and pulling down external sources.

jhgoodwin avatar Jun 15 '20 04:06 jhgoodwin