FSharp.Json icon indicating copy to clipboard operation
FSharp.Json copied to clipboard

Published 20 hours ago • verified publisher icon fsprojects

Q: Is there a reason why TimeSpan is not a Supported Type?

Open warren-pieterse opened this issue 3 years ago • 19 comments

Was wondering why TimeSpan is not in the Supported Types am I missing something?

warren-pieterse avatar Feb 18 '22 12:02 warren-pieterse

@vsapronov +1

AntyaDev avatar Jul 11 '22 16:07 AntyaDev

This repo seems to be a bit abandoned :-(

petrkoutnycz avatar Oct 24 '22 07:10 petrkoutnycz

@petrkoutnycz I've asked here whether @vsapronov would like to move to https://github.com/fsprojects.

There is also the option of forking there unless of course @vsapronov disapproves

dsyme avatar Oct 24 '22 20:10 dsyme

@AntyaDev What do you think?

dsyme avatar Oct 24 '22 20:10 dsyme

Hi @petrkoutnycz , @dsyme I did my personal fork with TimeSpan support: https://github.com/PragmaticFlow/FSharp.Json.New Also, I think it does make sense to move it to https://github.com/fsprojects

AntyaDev avatar Oct 25 '22 05:10 AntyaDev

@AntyaDev Do you think you could move that, and then use something to replicate the issues across from here? It seems to make sense? Unless @vsapronov thinks we shouldn't?

I will discuss with @sergey-tihon to add policies to fsprojects with regard to this kind of fork. Obviously we do it reluctantly and would want reconvergence if there's another development stream.

dsyme avatar Oct 25 '22 12:10 dsyme

I haven't seen any PRs for TimeSpan support. I would be glad to consider and merge it @AntyaDev.

vsapronov avatar Oct 25 '22 13:10 vsapronov

@AntyaDev I have checked your fork quickly. Is my understanding right that the required changes are mostly in files from FSharp.Data for TimeSpan support?

vsapronov avatar Oct 25 '22 13:10 vsapronov

Hi all, @vsapronov is willing to transfer to fsprojects, could we have one or two volunteers for maintainership please?

dsyme avatar Oct 26 '22 08:10 dsyme

Hi @vsapronov , Yes, you are right. And I think the tests were updated.

AntyaDev avatar Oct 26 '22 18:10 AntyaDev

@AntyaDev Could you be a co-maintainer in "fsprojects"? thanks

Or @petrkoutnycz would you be interested?

dsyme avatar Oct 28 '22 15:10 dsyme

Hi @dsyme ,

I'm afraid I will not be able to maintain it. I just physically don't have time on other OSS projects.

AntyaDev avatar Oct 30 '22 17:10 AntyaDev

I've never done any maintenance work in F#, but mostly because I don't know how!

I'm happy to stick my hand up and give it a try!

johnazariah avatar Oct 30 '22 20:10 johnazariah

I can do it as well, this project is my preferred way of json-ing things in F#. (I'm @carpenoctemdev on twitter)

tnishimura avatar Oct 31 '22 07:10 tnishimura

Fab, let's continue here : https://github.com/fsprojects/.github/issues/43#issuecomment-1296801832

dsyme avatar Oct 31 '22 09:10 dsyme

@vsapronov Per the above could you add @tnishimura and @johnazariah as co-maintainers please? I'll do it if you wish.

Also could you please add "fsprojects" as backup owner on the nuget package on nuget.org. Thanks.

dsyme avatar Nov 05 '22 11:11 dsyme

@tnishimura and @johnazariah - I have added you as maintainers to this repo. Please go ahead and do any of the necessary maintenance, pulls etc. Don't hold back.

@vsapronov Could you add fsprojects as co-owner on the nuget package please? https://www.nuget.org/packages/FSharp.Json, thanks! If we don't have that we'll have to do a namespace/package rename which would be unfortunate.

Thanks all!

dsyme avatar Nov 11 '22 01:11 dsyme

@dsyme, @tnishimura and @johnazariah don't worry I will add fsprojects to nuget. Sorry it takes me long time. Multitasking here...

vsapronov avatar Nov 11 '22 03:11 vsapronov

@vsapronov @tnishimura @johnazariah OK, I've added NUGETKEY in this repo to allow publishing FSharp.Json package (and nothing else) for the next year via actions from this repo. Keys time out after 365 days, need to be regenerated

dsyme avatar Nov 11 '22 11:11 dsyme