FSharp.Formatting icon indicating copy to clipboard operation
FSharp.Formatting copied to clipboard

Optional range information for Markdown elements

Open artempyanykh opened this issue 3 years ago • 2 comments

I'm looking into using the Markdown parser for a project, but noticed that the range information is optional for markdown elements. Glancing through the code I can see only 1 place where the range can become None but this looks accidental. Am I missing something? Or the range indeed should be present for all elements in the real world scenarios.

artempyanykh avatar Apr 22 '22 09:04 artempyanykh

@artempyanykh Yes, makes sense - please do submit a PR to make the ranges non-optional

dsyme avatar Apr 25 '22 03:04 dsyme

@dsyme thanks! I looked into it and it seems that something's off with some span ranges (potentially around links). It seems that markdown ranges need a bit more love than I can give ATM, but anyhow I filed a separate issue specifically around correctness of ranges in case things change #744.

artempyanykh avatar May 01 '22 16:05 artempyanykh