FSharp.Data icon indicating copy to clipboard operation
FSharp.Data copied to clipboard

CssSelect doesn't work as expected

Open a-a-k opened this issue 6 years ago • 4 comments

Please, direct me to a relevant closed/opened issue if that already exists. Here a part of my HTML (if need - you can explore it completely here)

Sample HTML

I've checked this examples before but when I'm trying to parse article elements by

doc.CssSelect "article[itemscope='']" 

or

doc.CssSelect "div.items.catalog-items > article"

or

doc.CssSelect "div.list.catalog-list article"

all these give me no results, can't figure out why. Also, even this construction gives me nothing

doc.CssSelect "div.list.catalog-list"

But this

doc.CssSelect "div.list" 

returns an element (howewer, also not that I searched).

Any supposes?

UPD

Is that related - https://github.com/fsharp/FSharp.Data/issues/1130?

a-a-k avatar Aug 04 '18 10:08 a-a-k

/cc @rflechner and @colinbull

ovatsus avatar Sep 01 '18 14:09 ovatsus

Looking at both issues it looks indeed like they are related. I myself am not that familiar with the CSS Selector code but I can give this ago at sorting this out. I need to start contributing to OSS again I have been rubbish for the last 2 years ;)

@ovatsus is everything still the same wrt build / dependencies now we are .net core compatible?

colinbull avatar Sep 01 '18 15:09 colinbull

Either building in VS2017 or "build All" from the command line should be the same as before

ovatsus avatar Sep 01 '18 15:09 ovatsus

@ovatsus Hey I was using FSharp.Data yesterday to play around with CSS and I am going to try and dig into some of these errors this weekend. I've never contributed to an open-source project before, but I'm looking forward to it!

ssimontis avatar Apr 05 '19 15:04 ssimontis