FSharp.Data.GraphQL icon indicating copy to clipboard operation
FSharp.Data.GraphQL copied to clipboard

Published 20 hours ago • verified publisher icon fsprojects

Relay Revamp

Open njlr opened this issue 1 year ago • 1 comments

The existing relay pagination code was synchronous, and therefore not usable against a real data-store.

This PR makes the types async and introduces some strong typing. This is a breaking change.

I also removed the old Relay sample, which no longer works anyway, and have added a new pagination sample.

The sample queries data from SQLite, which shows that it can work for real data-stores. The example is efficient in terms of data-fetching.

njlr avatar Jul 05 '24 17:07 njlr

Wow! Cool! I’ll review this weekend

xperiandri avatar Jul 06 '24 00:07 xperiandri

Wow! Cool! I’ll review this weekend

I need to update a few more things to fix the build first :+1:

njlr avatar Jul 06 '24 19:07 njlr

Let's migrate to voption (when reasonable) and interpolated strings in the code you change

xperiandri avatar Jul 07 '24 23:07 xperiandri

Wow! Cool! I’ll review this weekend

I need to update a few more things to fix the build first 👍

Now ready :+1:

njlr avatar Jul 19 '24 18:07 njlr

@njlr if you can address that for tomorrow I will review and merge that immediately and issue the new version of the packages as I want to use your new changes

xperiandri avatar Aug 31 '24 17:08 xperiandri

Comments addressed :+1:

njlr avatar Sep 01 '24 10:09 njlr

Amazing! @njlr have a look at my last changes

xperiandri avatar Sep 01 '24 11:09 xperiandri