FSharp.Data.GraphQL icon indicating copy to clipboard operation
FSharp.Data.GraphQL copied to clipboard

Added .editorconfig

Open xperiandri opened this issue 5 years ago • 13 comments

xperiandri avatar Apr 18 '20 19:04 xperiandri

@ivelten, @johnberzy-bazinga do you agree with these changes?

xperiandri avatar Apr 28 '20 16:04 xperiandri

@xperiandri I like to use this exact style in my .editorconfig files for .NET solutions. I think we could have this file to help maintain code formatting standards.

ivelten avatar Apr 28 '20 20:04 ivelten

Close in favor of #323

xperiandri avatar Mar 18 '21 21:03 xperiandri

@ivelten, @mickhansen, @nikhedonia

  1. What do you think about the proposed settings?
  2. Do you prefer the first or the second commit settings?
  3. Would you like anything to add? Maybe about JavaScript

xperiandri avatar May 19 '22 21:05 xperiandri

Now the right commits are in the right place

xperiandri avatar May 19 '22 21:05 xperiandri

This seems fine to me 👍 (with the caveat that I can't fully visualize what everything would look like just from the settings).

aggieben avatar May 19 '22 21:05 aggieben

Maybe you have your favourite preset 🙂

xperiandri avatar May 19 '22 22:05 xperiandri

To be honest I have not checked for recent new settings in Fantomas. So maybe I miss some of them

xperiandri avatar May 19 '22 22:05 xperiandri

@xperiandri I have no strong feelings about this :)

mickhansen avatar May 20 '22 05:05 mickhansen

Perhaps we should copy FSharp itself? https://github.com/dotnet/fsharp/blob/main/.editorconfig

njlr avatar May 20 '22 08:05 njlr

@njlr good idea. I had a look into into it and borrowed 1 settings

xperiandri avatar May 20 '22 12:05 xperiandri

So the latest commit has settings aligned with the latest Fantomas config (see)

xperiandri avatar May 20 '22 12:05 xperiandri

If no objections are provided today tomorrow I will update all the files according to config

xperiandri avatar May 20 '22 12:05 xperiandri