FSharp.Data.GraphQL icon indicating copy to clipboard operation
FSharp.Data.GraphQL copied to clipboard

Published 20 hours ago • verified publisher icon fsprojects

Deserialization

Open hth313 opened this issue 4 years ago • 4 comments

Deserialization of ID types caused an exception if the field was nullable.

This corrects https://github.com/fsprojects/FSharp.Data.GraphQL/issues/244 and adds a test-case for it.

hth313 avatar Feb 05 '20 03:02 hth313

@hth313 is this already fixed? Can we close this PR?

xperiandri avatar Sep 10 '22 21:09 xperiandri

I have no idea. I made a couple of PRs, some were merged but I do not think all of them. Not sure why and it was a long time ago. Looking at it now it seems that this was not merged, the misspelled "sring" is still there, but the actual fix does not match the code anymore. I really have no idea, I moved on, you can do what you feel is best.

hth313 avatar Sep 11 '22 06:09 hth313

As you can see I push this library forward. Soon we will have the latest GraphQL grammar support, CI&CD, solution template, etc.. So if you can check and update your PR I would appreciate that

xperiandri avatar Sep 11 '22 12:09 xperiandri

It is good to see healthy open source projects. Sadly I will most likely not be able to update the PR as I work in very different dev stacks these days. I do not have needed tools and VMs installed for this anymore.

hth313 avatar Sep 11 '22 17:09 hth313

@hth313 add me to you fork repo as editor, please

xperiandri avatar Dec 06 '22 12:12 xperiandri

You can just fork, clone or define a remote to it and pull things from it as needed. The project is here: https://github.com/hth313-forks/FSharp.Data.GraphQL/tree/deserialization

hth313 avatar Dec 07 '22 02:12 hth313