FSharp.Data.GraphQL icon indicating copy to clipboard operation
FSharp.Data.GraphQL copied to clipboard

Connection definitions should be optional by default

Open lxwbr opened this issue 7 years ago • 1 comments

@TOTBWF as a reminder.

Right now defining a connection produces something like this:

communities(first: Int, after: String): CommunityConnection!

but it supposed to be like this according to Relay (if you run Relay's compiler and execute pagination you would run into problems overwise):

communities(first: Int, after: String): CommunityConnection

Edit the creation of a connection definition accordingly. (change in the function connectionOf or something like this if I remember correctly)

lxwbr avatar Jul 21 '17 19:07 lxwbr

@zunder in this F# implementation nullability works in reverse - so everything is non-nullable by default, as nullability is well expressed via F# Option type, while contrary would be almost impossible using F# primitives.

If you need nullable connections you may mark them with Nullable(ConnectionOf Type).

Horusiath avatar Jul 21 '17 19:07 Horusiath

@xperiandri I think we can we close this one?

njlr avatar Oct 24 '22 21:10 njlr

@njlr thanks

xperiandri avatar Oct 24 '22 21:10 xperiandri