FSharp.Control.Reactive
FSharp.Control.Reactive copied to clipboard
fsprojects
Release with support for System.Reactive >= 6.0.
Description
@cloudRoutine @deviousasti @panesofglass
Can one of you please release a new version with support for System.Reactive >= 6.0. There are quite a lot of people waiting on this, see:
- https://github.com/fsprojects/FSharp.Control.Reactive/pull/172
- https://github.com/fsprojects/FSharp.Control.Reactive/issues/169
+1, having the same issue here
error NU1608: Warning As Error: Detected package version outside of dependency constraint:
FSharp.Control.Reactive 5.0.5 requires System.Reactive (>= 5.0.0 && < 6.0.0)
but version System.Reactive 6.0.0 was resolved.```
same issue here:
TrackTime -> MessageBox.Avalonia 3.1.5.1 -> DialogHost.Avalonia 0.7.7 -> System.Reactive (>= 6.0.0)
TrackTime -> FSharp.Control.Reactive 5.0.5 -> System.Reactive (>= 5.0.0 && < 6.0.0). TrackTime
I was looking at the build status, the build fails since this commit (but that of course might be a coincidence).
The build log from before that commit, and the log from that commit.
What immediately catches my eye is the msbuild version steps back from Microsoft (R) Build Engine version 17.1.0+ae57d105c for .NET to Microsoft (R) Build Engine version 14.0.25420.1.
But maybe more interesting, the whole build seems to be different.
When still working, .\build.ps1 is invoked but when no longer working msbuild is invoked directly?
I do not see this reflected in the commit history? Is this configured externally somewhere?
Side note: I cannot get this to build locally using visual studio, or by running
./build.ps1, any instructions for that?
Any news on this one? I'd gladly help if someone could explain me what to do. I also tried to build locally, but failed to.
Disclaimer: I know nothing about paket, I'm just trying to get the build working without knowing what I'm doing. Just to get the ball rolling.
@xperiandri The build broke when you added the groups to the paket.references file:
group Net472_or_less
System.Reactive
Microsoft.NETCore.Platforms
[snip]
And now I get a bunch of errors like the following when I run dotnet paket install:
Paket failed with
-> Installation Errors :
- C:\temp\FSharp.Control.Reactive\src\FSharp.Control.Reactive\paket.references uses the group Net472_or_less, but this group was not found in paket.lock.
- C:\temp\FSharp.Control.Reactive\src\FSharp.Control.Reactive\paket.references uses NuGet package System.Reactive, but it was not found in the paket.lock file in group Net472_or_less.
However, System.Reactive was found in group Build.
[snip]
When I remove the groups from paket.references, I can run paket install without problems and build.ps1 succeeds.
Alternatively, I can also add the groups to paket.dependencies each with their specific entry for the referenced packages:
group Net472_or_less
source https://api.nuget.org/v3/index.json
nuget System.Reactive >= 5.0
nuget Microsoft.NETCore.Platforms >= 5.0
group NetStandard2_0_or_less
source https://api.nuget.org/v3/index.json
nuget System.Reactive >= 5.0
nuget Microsoft.NETCore.Platforms >= 5.0
<etc>
group Net6_0
source https://api.nuget.org/v3/index.json
nuget System.Reactive >= 5.0
As I said, above I know nothing about paket, so I'm unsure how to proceed.
I've created a PR #177 that simplifies the packet files & updates the tooling and appveyor build spec.
It seems to build fine from dotnet build, dotnet fake build, and appveyor.
I merged in #177 and tried retriggering AppVeyor, but the build is still broken - I don't think I can fix it because it's in @panesofglass account. The build works fine for both @marklam and me (https://ci.appveyor.com/project/deviousasti/fsharp-control-reactive-hj870).
We could probably set up Github Actions - let's get shared ownership of that Nuget package.
FSharp.Control.Reactive is part of fsprojects org, so I can create a Nuget token with the right to push new packages and add to this repo (for GitHub Actions)
I can look at a github action which will version the package correctly for publishing it (version 5.0.6)
A new repository key added to this repo
with the right to push new versions of the package
@sergey-tihon Could you give me maintainer access to this repo so I can set up Actions? I have merge permissions, but I can't really see anything in the settings page.
@samritchie meanwhile you can consider https://github.com/fsprojects/FSharp.Control.R3/
This looks like it's waiting for #182 now. I have need of a package that requires System.Reactive >6, but I can't bring in that package because of FSharp.Control.Reactive. I also cannot install a nuget package from github in my environment. Is there anything I can do to help get the update published?
I've merged #182. I'll try to get this released ASAP. Sorry for the delay.
Released!
- https://github.com/fsprojects/FSharp.Control.Reactive/releases/tag/v6.1.0
- https://www.nuget.org/packages/FSharp.Control.Reactive/6.1.0
FSharp.Control.Reactive.Testing was not released, as @fsprojectsgit didn't have ownership of the repo. I'll try to get that resolved shortly.