Rename toList/toArray to toListSynchronously/toArraySynchronously

[blumu]

Calling Async.RunSynchronously in libraries is error-prone and can cause dead-locks. (e.g. when running on the main interactive thread.) I would just remove the two functions toList and toArray altogether to prevent library users from hitting hard-to-debug issues.

https://github.com/fsprojects/FSharp.Control.AsyncSeq/blob/9b608ff44e1d0c63c83a7de20e5e73a2f08660c2/src/FSharp.Control.AsyncSeq/AsyncSeq.fs#L1317

https://github.com/fsprojects/FSharp.Control.AsyncSeq/blob/9b608ff44e1d0c63c83a7de20e5e73a2f08660c2/src/FSharp.Control.AsyncSeq/AsyncSeq.fs#L1318

[dsyme]

It's true, though I certainly remember using these when playing around with AsyncSeq, testing and so on. Perhaps renaming to toListSynchronously and and toArraySynchronously may be right for now?

[eulerfx]

I'd second the rename. I agree that use of Async.RunSynchronously is troublesome and that these operations conceal it (particularly from a code quality scanner).