FSharp.AWS.DynamoDB icon indicating copy to clipboard operation
FSharp.AWS.DynamoDB copied to clipboard

Pin FSharp.Core dependency

Open bartelink opened this issue 1 year ago • 7 comments

Triggered by https://github.com/SwensenSoftware/unquote/issues/169

  • Add an explicit FSharp.Core dependency
  • Adjust inadvertent leak of Dotnet.ReproducibleBuilds into the package deps
  • Remove misleading inert superseded settings

bartelink avatar Apr 09 '24 08:04 bartelink

Build failure looks like it’s related to the StructuredLogger version in build.fsx, I’ll see if I can work out what it should be

samritchie avatar Apr 10 '24 01:04 samritchie

Looks like bumping it to 2.2.206 should work - @bartelink is it easier for you to update your branch?

samritchie avatar Apr 10 '24 01:04 samritchie

Also note I’ve considered bumping FSharp.Core to 6.0.7 as it looks like it will make life easier with tasks - I’ve been working on streams support using a Task based API. Not sure of the tradeoffs here though - open to suggestions.

samritchie avatar Apr 10 '24 01:04 samritchie

I think 6.0.7 is a good call - there's probably the odd gap closed in Arrray, Seq and stuff too You should be able to push to my branch if you gh pr to retrieve it (and 101 other ways) - in general feel free to do that, but I'll try now Yes it dos stand to reason the template is gone my main thing in all of this is for the package not to get a random dependency update due to unqote some day

bartelink avatar Apr 10 '24 05:04 bartelink

(Giving up for now; have time-sensitive stuff this side...)

bartelink avatar Apr 10 '24 06:04 bartelink

Thanks @bartelink - I’m off grid the next few days but will have a look on the weekend.

On 10 Apr 2024, at 2:09 PM, Ruben Bartelink @.***> wrote:



(Giving up for now; have time-sensitive stuff this side...)

— Reply to this email directly, view it on GitHubhttps://github.com/fsprojects/FSharp.AWS.DynamoDB/pull/75#issuecomment-2046603232, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AACLRRCUXH33AJILVHHZGKDY4TJQ3AVCNFSM6AAAAABF6E5DBOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBWGYYDGMRTGI. You are receiving this because you commented.Message ID: @.***>

samritchie avatar Apr 10 '24 23:04 samritchie

Thanks; it's not time sensitive from my perspective. If unquote reduces dependency to 6.0.0, probably updating unquote can be done as a follow-up to include in the next release ... or not yet, depending on when you want to do task stuff

bartelink avatar Apr 10 '24 23:04 bartelink