FAKE icon indicating copy to clipboard operation
FAKE copied to clipboard

Published 20 hours ago • verified publisher icon fsprojects

Core.Process: only set StandardEncoding if output/err is redirected

Open knocte opened this issue 3 years ago • 5 comments

Description

Should potentially fix https://github.com/fsprojects/FAKE/issues/2670

knocte avatar May 06 '22 05:05 knocte

@yazeedobaid I guess it was you who whitelisted me so that CI could run in this PR? I believe the macOS lane is not broken by my PR but because of a different issue which I filed here: https://github.com/fsprojects/FAKE/issues/2671

knocte avatar May 09 '22 14:05 knocte

@knocte yes I approved the CI run. For first-time contributors, the CI needs admin approval. Yes, it is not from your PR. It started to happen randomly after the last PR merge. It is happening on macOS only.

yazeedobaid avatar May 09 '22 15:05 yazeedobaid

Hi thanks for the PR Could you please rebase your branch from release/next? Now that the build has been fixed.

yazeedobaid avatar Jul 15 '22 17:07 yazeedobaid

Could you please rebase your branch from release/next?

Done.

knocte avatar Jul 16 '22 11:07 knocte

Thanks for the fix, can u please try to add tests to it?

yazeedobaid avatar Jul 21 '22 10:07 yazeedobaid