AzureStorageTypeProvider icon indicating copy to clipboard operation
AzureStorageTypeProvider copied to clipboard

WIP migrating to Azure Storage SDK 10.0

Open xperiandri opened this issue 6 years ago • 13 comments

xperiandri avatar May 26 '19 21:05 xperiandri

@xperiandri firstly thank you for creating this PR and apologies (I know we've spoken already about this) for the delay in getting to it.

At first glance, is there a reason why we need to move to three separate type providers? What are the benefits from both the user's point of view as well as development experience?

isaacabraham avatar Jun 18 '19 14:06 isaacabraham

@xperiandri I've picked up where I left off with the TP - basically the latest versions of F# have build issues relating to the use of the FSharp Compiler Tools dependency (which is coupled to F#4.1) so I'm removing that dependency, whilst also upgrading to FAKE 5. Once they're both out of the way (hopefully today) let's work together to get this ready to go in - I'm willing to split out into three assemblies as long as it's clear what the benefits are.

isaacabraham avatar Jun 18 '19 15:06 isaacabraham

Sounds good Was I wrong changing getting current executing assembly to getting current assembly?

xperiandri avatar Jun 18 '19 15:06 xperiandri

@xperiandri where? I'm just getting the current couple of branches merged into master and then will start looking at this PR in more detial.

isaacabraham avatar Jun 18 '19 15:06 isaacabraham

OK In TP initialization

xperiandri avatar Jun 18 '19 15:06 xperiandri

By the way, I would prefer to move to a model where you can create a provider with a connection string. Like ExcelProvider does.

xperiandri avatar Jun 18 '19 15:06 xperiandri

@xperiandri you can already do that?

isaacabraham avatar Jun 18 '19 15:06 isaacabraham

I mean dynamically. Now you either pass it into TP in code, or when calling a method

xperiandri avatar Jun 18 '19 15:06 xperiandri

So move away from method-based overrides to a single override at the "top" level? That's something I'd love to do. (btw you can specify a config file as well).

isaacabraham avatar Jun 18 '19 15:06 isaacabraham

Yes. Cool!

xperiandri avatar Jun 18 '19 15:06 xperiandri

Regarding get executing assembly vs current assembly using a type - both should work; is there any difference?

isaacabraham avatar Jun 18 '19 15:06 isaacabraham

I guessed that it will fix an issue with that you need to have Tables.json in all project referencing project with type provider

xperiandri avatar Jun 18 '19 15:06 xperiandri

I've rebased my changed on top of yours

xperiandri avatar Jun 20 '19 09:06 xperiandri