FSharp.Stats icon indicating copy to clipboard operation
FSharp.Stats copied to clipboard

Add Generalised Linear Models to FSharpStats

Open LibraChris opened this issue 1 year ago • 7 comments

Changes introduced in this PR

  • Implemented QR-based solver for GLMs
  • Added multiple tests for various GLM link and variance functions
  • Added functions for GLM statistics and documentation

Description

This PR introduces the GLM (Generalized Linear Models) module in FSharp.Stats. The key features include the implementation of an Iteratively Reweighted Least Squares (IRLS) solver on a QR-based solver for GLMs, enhancing the accuracy and performance of statistical modeling. Extensive tests have been added and updated to ensure robustness, covering various link functions and variance calculations. Documentation has been thoroughly updated to assist users in leveraging these new features effectively.

[Required] please make sure you checked that

  • [X] The project builds without problems on your machine

[Optional]

  • [X] Added unit tests regarding the added features

LibraChris avatar Jun 10 '24 12:06 LibraChris

Hey @bvenn, would you mind checking this out? Please squish all the commits if possible to avoid confusion. If there is anything I should add or change please let me know

LibraChris avatar Jun 10 '24 12:06 LibraChris

Hey @bvenn, anything you would change before the merge?

LibraChris avatar Jun 19 '24 11:06 LibraChris

Hey @bvenn, anything you would change before the merge?

Sorry, I was busy during the last weeks. I'll check out your PR this week.

bvenn avatar Jun 22 '24 19:06 bvenn

When watching the docs dotnet fsdocs watch --eval I noticed the API-Reference is broken. Nothing is displayed. I'm not sure if the cause lies within this PR or some error happened earlier. If you find time, you can check if it worked prior to your commits.

bvenn avatar Jun 23 '24 18:06 bvenn

When watching the docs dotnet fsdocs watch --eval I noticed the API-Reference is broken. Nothing is displayed. I'm not sure if the cause lies within this PR or some error happened earlier. If you find time, you can check if it worked prior to your commits.

The issue seems to be older than this PR or it is due to my setup. Could you check the docs in your machine?

bvenn avatar Jul 03 '24 05:07 bvenn

When watching the docs dotnet fsdocs watch --eval I noticed the API-Reference is broken. Nothing is displayed. I'm not sure if the cause lies within this PR or some error happened earlier. If you find time, you can check if it worked prior to your commits.

The issue seems to be older than this PR or it is due to my setup. Could you check the docs in your machine?

Try using the build target (build.cmd watchdocs), which should make sure that the necessary binaries are built before creating the docs

kMutagene avatar Jul 03 '24 06:07 kMutagene

I still get the following error during build watchdocs:

"System.Xml.XmlException: The ',' character, hexadecimal value 0x2C, cannot be included in a name. Line 15278, position 99" I think I fixed an issue similar to this within the last months.

@LibraChris your branch is 42 commits behind, if you could rebase, the issue may be gone

bvenn avatar Jul 03 '24 09:07 bvenn