zarchive-vim-fsharp icon indicating copy to clipboard operation
zarchive-vim-fsharp copied to clipboard

Support ALE

Open tunz opened this issue 7 years ago • 18 comments

ALE is an asynchronous syntax checker (similar with syntastic). it seems that syntastic does not support asynchronous for a while (https://github.com/vim-syntastic/syntastic/issues/699#issuecomment-285039618), and ALE is growing quickly. so, I think it's valuable to support ALE, and I'm actually using it.

Is it considerable?

tunz avatar Jun 09 '17 20:06 tunz

Cool. I wasn't aware of ALE. I will have to spend a bit of time looking at this. Thanks! On Fri, 9 Jun 2017 at 21:04, Choongwoo Han [email protected] wrote:

ALE https://github.com/w0rp/ale is an asynchronous syntax checker (similar with syntastic). it seems that syntastic does not support asynchronous for a while (vim-syntastic/syntastic#699 (comment) https://github.com/vim-syntastic/syntastic/issues/699#issuecomment-285039618), and ALE is growing quickly. so, I think it's valuable to support ALE, and I'm actually using it.

Is it considerable?

You can view, comment on, or merge this pull request online at:

https://github.com/fsharp/vim-fsharp/pull/82 Commit Summary

  • Add a wrapper for ALE

File Changes

Patch Links:

  • https://github.com/fsharp/vim-fsharp/pull/82.patch
  • https://github.com/fsharp/vim-fsharp/pull/82.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/fsharp/vim-fsharp/pull/82, or mute the thread https://github.com/notifications/unsubscribe-auth/ABIDlJ9TzcwV4v4UvZRX35Ezg0t8oa6Uks5sCaVOgaJpZM4N1x2b .

kjnilsson avatar Jun 09 '17 20:06 kjnilsson

Really sorry I haven't been able to spend more time on this. I think ALE support looks really promising. What is the story for using ALE and syntastic at the same time? Should users disable fsharp support for syntastic when using ALE and vice versa?

kjnilsson avatar Oct 03 '17 08:10 kjnilsson

I'm currently using only ALE. I've never tried to use both of ALE and syntastic at the same time. I guess users should disable one of ALE or syntastic.

tunz avatar Oct 03 '17 18:10 tunz

It could be really interesting. Any news on this?

palutz avatar Jan 19 '18 13:01 palutz

no news @palutz - I could do with a hand testing this with both ALE and syntastic installed.

kjnilsson avatar Jan 22 '18 17:01 kjnilsson

@kjnilsson, I actually tried but got some conflicts with both installed. I was also wondering if it's possible to have autocompletion/intellisense with vim-fsharp cause I'm not able to set it up (most of the time it's fine, but when trying some new libs it could be helpful)

palutz avatar Jan 23 '18 09:01 palutz

@tunz This file should be included in ale repo, not all vim-fsharp users use ale.

wsdjeg avatar Aug 23 '18 12:08 wsdjeg

@wsdjeg then why do we have syntastic support in this repo? not all vim-fsharp users use syntastic. this repository implemented interactions with fsautocomplete to find errors of codes, and this script is just wrapping the implementation.

tunz avatar Aug 23 '18 13:08 tunz

ok, it is a good reason.

wsdjeg avatar Aug 23 '18 13:08 wsdjeg

Hi, are there some advancements, please?

roper79 avatar May 26 '19 13:05 roper79

@kjnilsson FYI, I don't have any problem even when both of ale and syntastic are installed at the same time. Each of them works well.

tunz avatar May 27 '19 05:05 tunz

Any chance we can get this merged? Would be pretty useful.

PhilT avatar Jul 12 '19 08:07 PhilT

there are too many lint plugins. should this repo includ all of tham? why only ale?

still think this should be included in ale repo. as maybe ale's api may changed in future.

wsdjeg avatar Jul 12 '19 09:07 wsdjeg

Fair point but syntastic is no longer a sensible default. Perhaps Ale should be?

PhilT avatar Jul 12 '19 09:07 PhilT

I do not know, this should based on users choice, I use neomake


wsdjeg

-------- 原始邮件 -------- 主题:Re: [fsharp/vim-fsharp] Support ALE (#82) 发件人:Phil A Thompson 收件人:fsharp/vim-fsharp 抄送:Wang Shidong ,Mention

Fair point but syntastic is no longer a sensible default. Perhaps Ale should be?

― You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/fsharp/vim-fsharp/pull/82?email_source=notifications&email_token=ADEITEVXQB3R4T3JE7MUVHDP7BERNA5CNFSM4DOXDWN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZZHKCA#issuecomment-510817544, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADEITETHWFOPIPKGBLAKRXDP7BERNANCNFSM4DOXDWNQ.

wsdjeg avatar Jul 12 '19 09:07 wsdjeg

You're right. Maybe we are going about this wrong. ALE is all about supporting as many languages as possible. Perhaps we should add support in ALE instead.

PhilT avatar Jul 12 '19 14:07 PhilT

As an alternative, I see that ALE supports the Language Server Protocol. I would look at using the new LSP mode for FSAutoComplete and integrating that into ALE, as has been done for VSCode via Ionide and FSharp-Language-Server, and emacs via lsp-mode.

baronfel avatar Jul 12 '19 14:07 baronfel

I approve of this plan :)

On Fri, 12 Jul 2019 at 15:37, Chet Husk [email protected] wrote:

As an alternative, I see that ALE supports the Language Server Protocol. I would look at using the new LSP mode for FSAutoComplete and integrating that into ALE, as has been done for VSCode via Ionide https://github.com/ionide/ionide-vscode-fsharp and FSharp-Language-Server https://github.com/fsproj, and emacs via lsp-mode https://github.com/emacs-lsp/lsp-mode/blob/master/lsp-fsharp.el.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/fsharp/vim-fsharp/pull/82?email_source=notifications&email_token=AAJAHFDBIDTVY6NEMCLKFL3P7CJJBA5CNFSM4DOXDWN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZZ6BJY#issuecomment-510910631, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJAHFH6GIV2LFQRSX3TGBTP7CJJBANCNFSM4DOXDWNQ .

-- Karl Nilsson

kjnilsson avatar Jul 12 '19 19:07 kjnilsson