pytorch-rdpg icon indicating copy to clipboard operation
pytorch-rdpg copied to clipboard

Shouldn't Input of Critic be hidden state of RNN?

Open ychen306 opened this issue 7 years ago • 2 comments

Hi Faraz, I am studying the paper and your implementation is very helpful! I have a question though. It seems that the critic network in the paper takes in history -- which in this case is hidden state of the actor's LSTM, I presume -- rather than the observed state of the environment.

https://github.com/fshamshirdar/pytorch-rdpg/blob/master/rdpg.py#L139-L141

ychen306 avatar Nov 15 '18 05:11 ychen306

I was looking at exactly the same thing. Got your answer?

HassamSheikh avatar Feb 08 '19 01:02 HassamSheikh

I think this is a valid concern. Making state information available to the critic makes this implementation incorrect.

zhihanyang2022 avatar Apr 21 '21 09:04 zhihanyang2022