reuse-tool icon indicating copy to clipboard operation
reuse-tool copied to clipboard
verified publisher icon fsfe

Support deprecated licenses for download

Open carmenbianca opened this issue 3 years ago • 4 comments

Fixes #186

carmenbianca avatar Oct 12 '22 17:10 carmenbianca

Can't be merged; needs to use urllib instead of requests.

carmenbianca avatar Jan 11 '23 09:01 carmenbianca

Can't be merged; needs to use urllib instead of requests.

Would you please elaborate a bit about that problem? The code looks good to me.

Also, in order to fix #186 completely, should we perhaps only issue the message about a broken connection in case we can't download any licenses? We could even try to access a known-good license as a check.

floriansnow avatar Jun 16 '23 06:06 floriansnow

Would you please elaborate a bit about that problem? The code looks good to me.

After this PR was created, we merged a PR that removed the (direct) dependency on requests. The test code currently mocks/monkeypatches the requests library. We'll have to rewrite that line of code to use urllib instead.

Also, in order to fix https://github.com/fsfe/reuse-tool/issues/186 completely, should we perhaps only issue the message about a broken connection in case we can't download any licenses? We could even try to access a known-good license as a check.

I don't know. It would be nice to improve the error handling and/or error message here, but I'm more inclined to do that as a separate issue/PR.

carmenbianca avatar Jun 16 '23 08:06 carmenbianca