fsenf
fsenf
# Minimally invasive workflow for xarray transition Inspired by the interesting discussions we had the last couple of days, I was re-thinking how we could reach the goal to transition...
I created a branch [exp_iris2xarray](https://github.com/tobac-project/tobac/tree/exp_iris2xarray) (branched from main & merged RC_v1.5) where you can see the details in action
BTW: I did not change protection and review rules for this experimental branch. Happy if somebody can point me to the place where this can be done ...
@freemansw1 : Thank you for the suggestion! I actually have no experience with type hints and therefore cannot make a meaningful contribution to the discussion. However, I am not against...
Hi @JuliaKukulies , sounds good! Please go ahead and start a branch in your fork. I will not be able to catch up until Friday, anyway ;-) If we like...
I started work on `feature_detection.py`. - [ ] feature_detection_multithreshold - [x] feature_detection_multithreshold_timestep - [x] feature_detection_threshold - [x] feature_position - [x] filter_min_distance - [x] remove_parents - [x] test_overlap
*notes:* `def feature_detection_threshold` is using `numpy` arrays as input type -> this is inconsistent with our interface strategy -> however, I keep it for the moment.
OK, tests are in place for function `feature_detection_multithreshold`. However, they fail because `xarray` input is not convert into the correct `iris.Cube` format. `.coords` is empty: ```python if "time" not in...
@JuliaKukulies : maybe I misunderstood, but we actually have two testing function for `feature_detection_multithreshold` starting in [line](https://github.com/tobac-project/tobac/blob/26e6dcf5c2686e83730f4658f716ac4c4523f4ac/tobac/tests/test_feature_detection.py#L400) ```python def test_feature_detection_multiple_z_coords( ) def test_feature_detection_setting_multiple(): ) ``` I extended the first test...
@JuliaKukulies : Thanks for the hint! `make_dataset_from_arr` is now adjusted to output xarray with coordinates properly!