Fabian Braun comments

Results 459 comments of


                                            Fabian Braun

Add Django CMS 4 support

@stefanw Thanks for this work. Looks good at first sight! I will review in more detail, but * Uses API to create plugins 👍 * Respects CMS 4 toolbar object...

[DOC] Notes and minor errors in the doc

@mrbazzan Great observations! Would you like to come up with a PR?

[FEAT] Add a shortcut key to bring up the `Shortcuts` panel

This is happening in the JS. Take a look here: https://github.com/django-cms/django-cms/blob/develop-4/cms/static/cms/js/modules/shortcuts/help.js I have no idea why this might not be working, though.

[FEAT] Add a shortcut key to bring up the `Shortcuts` panel

@mrbazzan Is this still a topic?

Table properties are not editable when we maximise the editor

Can't reproduce. Try giving more details: what is not editable, what did you do before... Screenshot?

Table properties are not editable when we maximise the editor

@vipulnarang95 Yes, I did. And I cannot reproduce the issue. :-( Any custom or non-standard CKEditor4 plugins? Also, I notice that in your first example you're editing an `HTMLField` and...

Table properties are not editable when we maximise the editor

Final thought: Your dropdown menu is somewhat too large in your first screenshot, and seems to have zero height in your second screenshot. Any CSS at work that interferes with...

Table properties are not editable when we maximise the editor

@vipulnarang95 I still cannot reproduce this behaviour with current djangocms-text-ckeditor 5.1.6, neither for a Text plugin nor for an `HTMLField`. Can you check which CSS rule defines the height of...

Table properties are not editable when we maximise the editor

Closing this issue since djangocms-text-ckeditor is now deprecated and replaced by djangocms-text.