Fabian Braun

Results 459 comments of Fabian Braun

I think this is an interesting point, and that a refactor seems possible w/o knowing about any details of versioning. Ideally, versioning (or no-versinging) needs not to change anything with...

The CMS itself has the means of managing this distinction (`admin_manager`). I think that's worth a try. Then the CMS implementation would be a reference for other models (besides pages)...

djangocms-versionings `cms_menus.py` is now deprecated.

@svandeneertwegh I have two observations: * Upon confirming to discard changes, the modal does **not** close. Instead, the version list of the object is shown in the modal. I think...

This happens when only one language is configured: django CMS does not offer the language menu any more (since there are no language actions). djangocms-versioning incorrectly assumes that a language...

This is intentional. This allows navigation to not yet published pages using the menu when editing. Note: The menu renderer of djangocms-versioning will be deprecated in the next version. It...

It might make sense to separate out the if statement (lines 250ff) into a separate method of the `CMSMenu` class which would allow customization by subclassing.

I close this issue since the `cms_menus.py` are deprecated.

@rolandf I have not looked into this but remember that I had to adapt `templates/djangocms_modules/render_module.html` to get a meaningful display the modules. Might this also be a way for you,...