puppet-redis icon indicating copy to clipboard operation
puppet-redis copied to clipboard

redis.conf.erb template is tighly coupled to Redis 2.x and breaks with 3.x Redis deployments

Open grantholly opened this issue 7 years ago • 2 comments

After upgrading to Redis 3.2, puppet runs are now deleting the entire contents of Redis.conf. The heart of the issue if the redis.conf.erb template does not contain a block for Redis 3.x versions.

Here is the relevant bit of code in init.pp: https://github.com/fsalum/puppet-redis/blob/master/manifests/init.pp#L118

And here in redis_version.rb: https://github.com/fsalum/puppet-redis/blob/master/lib/facter/redis_version.rb#L18

When you go through the case statement in redis_version.rb, and you get the default of nil because 3.x versions have no matching case, and the value of $::redis_version of nil causes the problem with your redis.conf getting nuked.

grantholly avatar May 23 '17 23:05 grantholly

I am also plagued by this issue as well, but with Redis version 4, @grantholly did you fix it manually in the two files or did you move to another package?

emerham avatar Jan 26 '18 16:01 emerham

I ended up not using this module

grantholly avatar Aug 31 '19 20:08 grantholly