Feras Saad
Feras Saad
CGPM is written very defensively in that methods throughout perform significant error checking on their inputs (sometimes as `assert` but typically by raising a `ValueError`. Advantages: - [ ] comprehensible...
https://github.com/probcomp/cgpm/blob/9237e19a7d4523a1984f4380f77d55ba7ac4cbdf/tests/test_gpmcc_simple_composite.py#L126-L130 1. The test is disabled since it does not start with `test_`. 2. The hooked CGPMs have duplicate output identity `[5]`.
- [ ] identify all imports of matplotlib - [ ] convert the necessary ones (e.g. tests) to use the agg backend
https://github.com/probcomp/cgpm/blob/91cd8f7f6fce769d7e57f2b33bee2be6cd12ca3b/src/crosscat/state.py#L376-L377 https://github.com/probcomp/cgpm/blob/91cd8f7f6fce769d7e57f2b33bee2be6cd12ca3b/src/crosscat/state.py#L363-L364
``` RuntimeError: Subprocess failed: Traceback (most recent call last): File "/scratch/fsaad/cgpm/cgpm/utils/parallel_map.py", line 50, in process_input ok, fx = True, f(x) File "/scratch/fsaad/cgpm/cgpm/crosscat/engine.py", line 37, in _intialize state = State(X, rng=gu.gen_rng(seed),...
- [ ] Enable diagnostics and checkpointing. - [ ] Kernel counts - [ ] History of column partition and state CRP. - [ ] History of logscore. - [...
Diagnostic func should take the state and performs arbitrary operations. Makes it easier to run transitions with arbitrary diagnostics at some amount of checkpoints, without the client having to pause...
Currently assumes that incorporate includes all the columns in the dim, so it is a the row-level not the cell-level. Incorporating on a cell-basis requires additional checking, for example ensuring...