Feras Saad

Specifically the following lines https://github.com/probcomp/cgpm/blob/46e1d8d931fa81b2f4c3b4ff4575d9f8da1ef635/src/primitives/poisson.py#L146-L170 The posterior predictive distribution should be a negative binomial with n = a' and p = 1 / (1 + b'), or possibly p =...

vscgpm: implement VsCGpm.logpdf

1

TODO: Write design issues -- short version is that logpdf estimators are hard!

vscgpm: make output SPs accepted a single inputs dictionary, rather than input names.

1

Therefore, every output SP will have the form ``` assume sim_output = mem((rowaddr, inputs) -> {...}; ``` as opposed to the current convention ``` assume sim_output = mem((rowaddr, apogee_km, perigee_km)...

vscgpm: hooked instance of VsCGpm is incompatible with Engine(multiprocess=True)

1

`engine.compose_cgpm([vscgpm], multiprocess=True)` fails with ``` E RuntimeError: Subprocess failed: Traceback (most recent call last): E File "/scratch/fsaad/cgpm/cgpm/utils/parallel_map.py", line 55, in process_input E outq_wr.send((i, ok, fx)) E PicklingError: Can't pickle :...

```python self.obs = defaultdict(lambda: defaultdict(dict)) ``` No reason for such a wacky data structure causes bug after bug.

Currently, the user is expected to provide a list in the inference language named `observers` which contains the observation function for each simulator defined the `simulators` list (which lives in...