rails-base icon indicating copy to clipboard operation
rails-base copied to clipboard

Introduce Webpacker and component approach

Open DanilAgafonov opened this issue 6 years ago • 2 comments

Summary

In this PR we replace Asset Pipeline with Webpacker.

  • [ ] Adapt markup for Foundation 6.4. (Flexbox and Float grids has been deprecated and now we need to use XY grid: app/views/application/_footer.html.slim already adapted) (Pagination need to be updated too)
  • [ ] Use component approach (https://evilmartians.com/chronicles/evil-front-part-1)
  • [ ] Review styles previously located in app/assets/stylesheets/components/. Maybe this styles are not needed now. If they needed, move it as style for specific component.

Test plan

List of steps to manually test introduced functionality:

  • Go to Application
  • Sign in
  • ...

Review notes

While reviewing pull-request (especially when it's your pull-request), please make sure that:

  • you understand what problem is solved by PR and how is it solved
  • new tests are in place, no redundant tests
  • DB schema changes reflect new migrations
  • newly introduces DB fields have indexes and constraints
  • routes are RESTful, no useless routes
  • there are no missed files (migrations, view templates)
  • required ENV variables added and described in .env.example and added to Heroku
  • associated Heroku review app works correctly with introduced changes

Deploy notes

Notes regarding deployment the contained body of work. These should note any db migrations, ENV variables, services, etc.

DanilAgafonov avatar Aug 24 '18 13:08 DanilAgafonov

@DanilAgafonov lets maybe find some time and finish this work? Let me know how I can help here

vladimirbazhanov avatar Feb 10 '19 18:02 vladimirbazhanov

I'' close this PR shortly because we already applied almost all features from it into master. Thanks for great work here!

vladimirbazhanov avatar Jul 13 '20 06:07 vladimirbazhanov