genshin-optimizer icon indicating copy to clipboard operation
genshin-optimizer copied to clipboard

Change migration naming structure

Open StainAE86 opened this issue 11 months ago • 4 comments

Suggestion to change this: image

To this: image

StainAE86 avatar Mar 04 '24 10:03 StainAE86

I think this is a good idea, but the issue is that the migration happens on the database side, which has no access to the translation or character name system. I think it would be prohibitively difficult to pipe that data in, just for this one case of migration.

frzyc avatar Mar 04 '24 19:03 frzyc

It doesn't look like you need any translation here. Just use the CharacterKey instead of the full name and its the same effect

nguyentvan7 avatar Mar 04 '24 19:03 nguyentvan7

Stain's ask was: "Loadout Name" -> "<Character> Team Loadout" "Migrated from <Character>" -> "<Character> Team"

nguyentvan7 avatar Mar 04 '24 19:03 nguyentvan7

I guess we can use the character key then.

frzyc avatar Mar 04 '24 19:03 frzyc