genshin-optimizer icon indicating copy to clipboard operation
genshin-optimizer copied to clipboard

Published 20 hours ago • verified publisher icon frzyc

Simplify optimization tab

Open nguyentvan7 opened this issue 1 year ago • 5 comments

Describe your changes

  • Split Artifact conditional config into its own modal, as it is more of a prerequisite to optimization, and shouldn't be part of the optimization filters
  • Hide all optimization filters behind a modal to reduce visual stress
  • Change layout of optimization selector/optimize button to be more obvious
  • Hide graph information behind an accordion to reduce confusion
  • Change artifact set cards to show highest rarity for the background color
  • Change allowlist default state to be "custom list", so we are as permissive as possible for first optimization

Issue or discord link

  • Resolve #1455

Testing/validation

New optimize tab layout, featuring art set conditional modal button, artifact filter modal button, new opt selector/start layout and graph behind an accordion image

Graph accordion expanded without a graph image

Graph accordion expanded with a graph image

Artifactfilter modal image

Artifact set conditional modal image

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • [ ] I have commented my code in hard-to understand areas.
  • [ ] I have made corresponding changes to README or wiki.
  • [ ] For front-end changes, I have updated the corresponding English translations.
  • [ ] I have run yarn run mini-ci locally to validate format and lint.
  • [ ] If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

nguyentvan7 avatar Feb 19 '24 21:02 nguyentvan7

[sr-frontend] [Mon Feb 19 21:14:26 UTC 2024] - Building version 0df7722977c10585a7e2bf59c2bf2ffa345ed92c

[frontend] [Mon Feb 19 21:14:28 UTC 2024] - Building version 0df7722977c10585a7e2bf59c2bf2ffa345ed92c

[sr-frontend] [Mon Feb 19 21:14:29 UTC 2024] - Building version 3f85f3b5e6b85a291a490249c32cc7cf35a9b577

[sr-frontend] [Mon Feb 19 21:15:50 UTC 2024] - Deployed 0df7722977c10585a7e2bf59c2bf2ffa345ed92c to https://genshin-optimizer-prs.github.io/pr/1514/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon Feb 19 21:17:00 UTC 2024] - Deployed 3f85f3b5e6b85a291a490249c32cc7cf35a9b577 to https://genshin-optimizer-prs.github.io/pr/1514/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon Feb 19 21:21:41 UTC 2024] - Building version 0013756cb5780601ff423c78ba57f73169ee77d3

[sr-frontend] [Mon Feb 19 21:21:46 UTC 2024] - Building version 0013756cb5780601ff423c78ba57f73169ee77d3

[sr-frontend] [Mon Feb 19 21:23:11 UTC 2024] - Deployed 0013756cb5780601ff423c78ba57f73169ee77d3 to https://genshin-optimizer-prs.github.io/pr/1514/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon Feb 19 21:24:12 UTC 2024] - Deployed 0013756cb5780601ff423c78ba57f73169ee77d3 to https://genshin-optimizer-prs.github.io/pr/1514/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon Feb 19 21:31:53 UTC 2024] - Building version 0a77a5d82bff8e5e0b9920af5c6dc44aacf8e90d

[sr-frontend] [Mon Feb 19 21:31:54 UTC 2024] - Building version 0a77a5d82bff8e5e0b9920af5c6dc44aacf8e90d

[sr-frontend] [Mon Feb 19 21:33:30 UTC 2024] - Deployed 0a77a5d82bff8e5e0b9920af5c6dc44aacf8e90d to https://genshin-optimizer-prs.github.io/pr/1514/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon Feb 19 21:34:32 UTC 2024] - Deployed 0a77a5d82bff8e5e0b9920af5c6dc44aacf8e90d to https://genshin-optimizer-prs.github.io/pr/1514/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Mon Feb 19 22:19:20 UTC 2024] - Building version c75fe499b697f0241c48e73dccc34156fc8f42e5

[frontend] [Mon Feb 19 22:19:23 UTC 2024] - Building version c75fe499b697f0241c48e73dccc34156fc8f42e5

[sr-frontend] [Mon Feb 19 22:20:55 UTC 2024] - Deployed c75fe499b697f0241c48e73dccc34156fc8f42e5 to https://genshin-optimizer-prs.github.io/pr/1514/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon Feb 19 22:22:00 UTC 2024] - Deployed c75fe499b697f0241c48e73dccc34156fc8f42e5 to https://genshin-optimizer-prs.github.io/pr/1514/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Tue Mar 5 19:38:22 UTC 2024] - Deployed 99cd7c121580480e4fb54af23e0dfb15db3238d5 to https://genshin-optimizer-prs.github.io/pr/1514/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Tue Mar 5 19:46:20 UTC 2024] - Deployed d1f2776edb6b2cace886c61be1d7066f7bdc84d8 to https://genshin-optimizer-prs.github.io/pr/1514/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Mar 5 19:47:14 UTC 2024] - Deployed d1f2776edb6b2cace886c61be1d7066f7bdc84d8 to https://genshin-optimizer-prs.github.io/pr/1514/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Mar 5 19:49:05 UTC 2024] - Deployed 468320956f5aa2df5a94af84d8c7c0fdf567922a to https://genshin-optimizer-prs.github.io/pr/1514/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Mar 5 19:55:36 UTC 2024] - Deployed 9cf23d1eabaaf759b5820f93404c4b21e4fe37e5 to https://genshin-optimizer-prs.github.io/pr/1514/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Mar 5 20:32:28 UTC 2024] - Deployed 92139e1b27f041d036a08c999f461ff6cbb3ed74 to https://genshin-optimizer-prs.github.io/pr/1514/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Mar 5 20:53:12 UTC 2024] - Deployed a90b0d4c28b90392b297dad869c8b6c6e45de5c7 to https://genshin-optimizer-prs.github.io/pr/1514/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Mar 5 21:06:29 UTC 2024] - Deployed d9c94fc042722070c19570935554b67bd05a2535 to https://genshin-optimizer-prs.github.io/pr/1514/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Wed Mar 6 06:08:16 UTC 2024] - Deployed 482e80e1cb5c0d63291bf961ed889861e64ada30 to https://genshin-optimizer-prs.github.io/pr/1514/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Fri Mar 8 17:29:33 UTC 2024] - Deployed fdf0acb87030d23f167750da76d71e82ae696bde to https://genshin-optimizer-prs.github.io/pr/1514/frontend (Takes 3-5 minutes after this completes to be available)

github-actions[bot] avatar Feb 19 '24 21:02 github-actions[bot]

image Some additional comments to this new modal:

  • Move the title and [X Selected] to the modal title ( as well as moving some extra elements there)
  • convert the information at the top to an info Alert
  • minimize padding on the conditional selectors. (can we try removing all padding? might be confusing some conditional with multi-select conditional

frzyc avatar Mar 05 '24 23:03 frzyc

image

  • Since this modal is primarily dealing with filtering artifacts, we should rename the title to "Artifact Filters", and show the total artifacts filtered

frzyc avatar Mar 05 '24 23:03 frzyc

Also missing this button introduced in https://github.com/frzyc/genshin-optimizer/pull/1602 image

frzyc avatar Mar 06 '24 03:03 frzyc

  • [ ] Refine layout for forced 2 column setup (optimize buttons should be on the bottom right?)
  • [ ] Fix height of optimize buttons in forced 2 column setup
  • [ ] Experiment with a permanent 2 column setup with the optimize buttons in the bottom right
  • [ ] Remove default change to allowlist setting

nguyentvan7 avatar Mar 06 '24 17:03 nguyentvan7

Likely too stale and too radical to merge in. Will take lessons and try to break down the useful parts from this PR for implementation later.

frzyc avatar Jul 21 '24 18:07 frzyc