Upgrade Optimizer "Artifact Set Assumptions"

[StainAE86]

This is a request for @tooflesswulf fork of Optimizer to see how well it can be implemented before the functions are folded into the main Optimizer.

Currently the shortfall of Upgrade Optimizer is it only finds an instant upgrade for 1 slot without any consideration how the rest of the build could change as a result.

A suggestion would be to include two extra check box functions:

1. "Assume all potential artifacts don't break the current equipped set(s)"
2. "Assume all potential artifacts complete their respective set"

So for an example of 1); Your character has 4pc Crimson Witch equipped and an offset Goblet. The Upgrade Optimizer finds a Gilded Dreams Circlet that would result in a better build if the build remained 4pc Crimson. This means you would have to eventually get an equal or better Crimson Goblet for this build to actually be better.

And an example of 2); Your character has 4pc Crimson Witch equipped. The Upgrade Optimizer finds a Gilded Dreams artifact that would result in a better build if all the currently equipped artifacts were already Gilded Dreams. (Essentially just converting your 4pc Crimson to 4pc Gilded, retaining their current main/sub stats) This allows you to find new great artifacts for your character to eventually construct a better build utilizing a different set.

Obviously this needs to be communicated to the end user in a way that makes it obvious what the function does and why they would want to use it. But that is the job of the final UI design when the toofless branch is implemented into the main Optimizer.

[StainAE86]

Link to TaqPCR's conversation on their feature request to account for artifact swaps: https://discord.com/channels/785153694478893126/819643218446254100/1114855048959230002

From what I can tell their method is trying to capture greater detail but is very narrow in its scope when assuming it is only the off piece that could change.

Since it does not account for this situation:

You have 4pc Emblem with a Crit Rate circlet and a off set Sands. But you also have an absolutely amazing Emblem Crit DMG circlet. However you simply don't have the combination of other pieces to get enought Crit Rate from substats alone to allow using the Crit DMG circlet.

Your current Emblem Feather heavily rolled into Crit DMG, but you have a +0 Emblem Feather with the potential to give you enough Crit Rate to allow for the swap to the Crit DMG circlet and increase the overall build output. But it doesn't currently come up in the Upgrade Optimizer because no matter how well it rolls the resulting build would be worse than your current high Crit DMG Feather without also factoring in the swap to the Crit DMG circlet.

At no point did your off set Sands get considered.

[StainAE86]

Here is another idea. Introduce the Upgrade Optimizer into the main Optimize page:

Include a check box option to "Show a single potential improved build" bundled with the "Assume Level" function. Which will calculate the potential substat rolls of a single piece which if rolled perfectly will provide an increase to the current best build.

Then if the user selects "5 builds" for example they will get an additional build in 1st place that has the highest (or near to highest) potential to be better than the actual results if that artifact levels to its potential. (and if such a combination exists in their database)