fry69

Results 270 comments of fry69

Fresh 1 plugins are not supported in Fresh 2. Also using `esm.sh` is discouraged, see here -> https://fresh.deno.dev/docs/advanced/troubleshooting#dont-use-esmsh

@marvinhagemeister I was referring to this part, I should have made this more clear in my response: > but my project is meant to be a Fresh plugin

I strongly object to this. `.fresh` is a hidden folder, those usually reserved for configuration files or ephemeral caches. Generated output should be visible in a clearly marked/named folder. Common...

Simple reproduction repo for this issue -> https://github.com/fry69/fresh-vite-vanilla-repro Just run `deno task build` to provoke mentioned error.

> `(0 , __vite_ssr_import_0__.createDefine) is not a function` This smells like something is not right in your code IMHO, but without seeing the whole thing it is hard to tell....

@DontMash This all looks good and should absolutely work. As a last resort I can recommend to wipe out Deno's cache and see if that helps: ```shell deno clean ```

@DontMash FYI and for future reference: The core problem for this bug to trigger seems to be a `package.json`/`node_modules` existing in a parent folder, see this issue: https://github.com/denoland/deno/issues/30911 This only...

Adding so many or so big files that aider feels slow seems to be a bad idea in the first place IMHO. Not sure if we should fix or optimize...

This might give a hint: ``` Warning "nodeModulesDir" field can only be specified in the workspace root deno.json file. at file:///deno-playground/src/fresh-project/deno.json ```

Your reproduction works fine for me when I move this property to the root `deno.json` file (also I recommend to use `manual` currently, as `auto` is a bit buggy): ```json...