Fabian Ruffy
Fabian Ruffy
> > > If yes, it would be nice to see one example of that. It is perfectly fine if it is checked in as part of some future PR,...
Part of the reason these linters exist is for style consistency and to offload some of the review work to automated tools. I think we should have even more linters,...
> I have not found the rationale behind the `#include` order in the Google Style guide. Yeah I do not think there is one provided. Afaik the reason is a)...
Should we merge this? What is the reason for this change?
I think it is because we are not fixing the protobuf dependency in CI. The CI uses `3.21.6`.
It looks like the correct behavior according to https://github.com/p4lang/p4c/blob/main/frontends/p4/tableKeyNames.cpp#L110 but the STF runner can not parse these types of names.
Well, it is happening frequently enough to become noticeable. I do approve a fair bit of pull requests. In particular, first-time contributors who push frequently are constantly blocked waiting for...
The reason libbpf was added is that the Ubuntu 16.04 bpf headers were mismatched with the what the kernel provided. libbpf is designed to be kernel-agnostic and makes the generated...
Hi @DoctorNoobingstoneIPresume are you planning to continue work on this? It looks very useful.
@mbudiu-vmw mentioned that there are a few existing facilities that perform similar analysis in p4c. We can take a closer look at how to improve the existing pass before migrating...