Fabian Ruffy

Results 266 comments of Fabian Ruffy

Unfortunately, we currently do not have people dedicated to fixing bugs in the front-end.

>I would be quite weary of macros, especially like the one you suggested that contains return. It would effectively be the same as the Protobuf status macros, which are used...

You need to add pass somewhere [here](https://github.com/p4lang/p4c/blob/main/backends/p4test/midend.cpp#L83). Although the simple switch mid end does use it, so the bug should be caught by the STF tests. https://github.com/p4lang/p4c/blob/main/backends/bmv2/simple_switch/midend.cpp#L105 I can try...

You are right, there will be a series of failures. For reference, this is the PR that disabled it: https://github.com/p4lang/p4c/pull/3916 I was curious whether validation will pick it up. https://github.com/p4lang/p4c/actions/runs/7697736211/job/20975378374#step:5:1793...

This looks like a problem with the [parserUnroll](https://github.com/p4lang/p4c/blob/main/midend/parserUnroll.h#L298) pass. P4Testgen uses it. That pass is unfortunately quite complex and I do not know it very well. This might be difficult...

> These are SIGSEGV, should be easy to diagnose and fix. Well the crash happens at [here](https://github.com/p4lang/p4c/blob/main/midend/parserUnroll.cpp#L175) because it is trying to clone the constant of an uninitialized `SymbolicInteger`. Why...

The failure is caused by instability in `infrap4d`. You can ignore it as this run is not required for merging.

The encountered bug is covered in #4200.

Is this ready to be merged?

> Hi! This looks like quite an interesting idea. Would this allow easily adding target platforms similarly to P4 testgen? What is currently missing for this to be non-WIP? There...