Fabian Ruffy

Results 266 comments of Fabian Ruffy

That would definitely be nice. The biggest hurdle is patching together the package, which can be in arbitrary order. With https://github.com/p4lang/p4c/pull/4267 it should be easier, since we can just relax...

> My idea was to define a very simple arch (and a fixed one, so I was not thinking about having flexibility there as @fruffy's comment seems to suggest). Maybe...

Now that the library extension is in this should be much easier to prototype.

That could also be an option, I think for sanity's sake, Ubuntu 16.04 needs to be eventually deprecated to keep up with all the eBPF/XDP changes. Another reason to get...

> That said, these are not something easy or isolated changes as Visitors are everywhere :) One thing to start with this is to introduce a new visitor class in...

I personally do not know much about the choices made for the visitors, so your guess is as good as mine. When does a visitor need to be copied, for...

> IMO all this is very misleading and could lead to subtle issues everywhere. We certainly need to stop accepting Visitor by const reference in PassManager Intuitively I would say...

> There are cases when an `Inspector` is used in a pipeline and later the collected results are reused. See e.g. https://github.com/p4lang/p4c/blob/main/frontends/p4/frontend.cpp#L238 Ah, I definitely have used this pattern before....

Any chance some of the code using it can be upstreamed? Would make it clearer how to use it.