Fabian Ruffy

Results 266 comments of Fabian Ruffy

>Yes of course, sorry, by "revert" I just mean we should remove the second SimplifyDefUse pass. You are correct that https://github.com/p4lang/p4c/commit/e60cb8a633e305a75cb28c56dbd3d1dbccc871c8 fixed bugs in the pass and those fixes should...

I have lost track on this. It seems fixed but what about the other related regressions? https://github.com/p4lang/p4c/labels/regression

Byte order is a long-standing problem in the eBPF back end. https://github.com/p4lang/p4c/issues/1122 Does this PR address the issue? We may not even need to make the distinction between "TC" and...

The goal is that you should be able to run `cmake .. -DCMAKE_LINT_ONLY=ON && cmake cmake --build build --target clang-format` with minimal dependencies installed. Please apply the following patch. After,...

> @asl @fruffy @thantry and anyone else with interest -- there will likely be some discussion of this in the next P4 Language working group meeting on May 6 (https://p4.org/working-groups/)...

> Do we want to add `abseil-*` checks here? Sure.

@ChrisDodd > > With type you mean a typedef? > > typedef or nested struct Unfortunately, there is no way to distinguish between a private and public typedef for now....

> Do you prefer to enforce this (by a CI check)? We are still missing Clang-tidy support for this (https://github.com/p4lang/p4c/pull/4254). > Did you try how large changes are needed to...

> Would the clang-tidy still run very slowly if you disabled all the checks except for the formatting once? Yes, I have not found a way yet. But even having...

@vlstill Should we rebase this PR. Things might be easier after recent updates.