Fabian Ruffy
Fabian Ruffy
> > I'd like to push back on the unconditional part a bit. I can see cases where downstream projects may want to supply their own types to a particular...
> In this case the parameter `type` shadows the field `type`, so the field get initialized in the base constructor, and then the assignment of bool here modifies the parameter...
> > Maybe all of these "get" functions should be static class members? > > Do you mean e.g. `IR::StringLiteral::get`? Yes, something in that form.
> > > > Maybe all of these "get" functions should be static class members? > > > > > > > > > Do you mean e.g. `IR::StringLiteral::get`? >...
This PR is still a draft, is it ready?
> > For the outdated link to `bcc`, it might be nice to explicitly mark it as a "historical reference only". > > Sure ! So should leave a link...
> Any suggestions on this outdated link? > > > ## 2nd outdated link > > This might not be that significant. [current link](https://mail.python.org/pipermail/python-list/2012-August/628809.html) > > https://github.com/p4lang/p4c/blob/8d21a8b4f2dce71c51ede5a23f891a9f6b8cff2d/tools/cpplint.py#L4834-L4835 You can ignore...
@tatry @osinstom
Closing in favor of https://github.com/NIKSS-vSwitch/nikss/issues/109.
Could you inline the outputs you have gotten from each program using the Github code formatting? It will make it easier to read the issue. The error reports are working...