Israel Fruchter
Israel Fruchter
Hi @tillahoffmann and @SergeyPirogov, pretty please for approving the workflow to start ? FYI, it can be eased a bit, the approval part: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#configuring-required-approval-for-workflows-from-public-forks
> Thanks for the additions and apologies for the slow reply. A few things to get this integrated: > > * Rebase on master. > * Regenerate requirement files. >...
@yakimka @tillahoffmann waiting for approval for running the CI
> We may have to get #209 merged first to get around the google dependency issue. Seems that just removing the pinning helped
> I have a relatively strong preference to remove the cache for two reasons. First, it's more code to maintain. Second, I don't think the caching will help in most...
> We may have to get #209 merged first to get around the google dependency issue. @tillahoffmann would it be o.k. to take the code changes from #209, and test...
I think this feature is still useful, since setting the max number can be britle, and as time pass it would you would need to enlarge it. I guess one...
nice, more reason to move to pytest. @roydahan FYI
thanks @hugovk, this anyhow would be a good incentive to move to pytest...
@slivne you wanted a reproducer, here it is: https://gist.github.com/fruch/b3623f68bf8dba65c44133ba1288f418 It started happening, once I've changed node3 address... I think this can explain the network not connecting, since the other nodes...