Israel Fruchter
Israel Fruchter
Why not todo all the `wait_other_notice` logic after `wait_for_binary_proto` ? as it in `scylla_cluster.py` ? why split it into two parts like that ?
> it's possible, although the other node notice this node as up before it starts listening for cql, but that shouldn't matter. > > However, if only wait_other_notics is set,...
I think server side DESCRIBE should solve this one...
> @fruch - shall I move it to cqlsh repo? You can move it But it would need to be part of the scylla core as well, cause the server...
> I assume you refer to > > https://github.com/scylladb/scylla-bench/blob/12020ff90cacd0dbfabebfe488029978429f3efa/main.go#L125 yes, doing this at the same time from multiple processes, on a cluster that is ready is with substantial load, joining...
@avelanarius @Lorak-mmk I this one should go into your team backlog.
The only concern I see here, is that the next pull from upstream is gonna be painful... Beside that if all tests pass Also why do this cleanup now ?...
looks like upstream are gonna take it slowly... maybe we should just merge it, if we confident enough with the changes, maybe it move upstream a bit faster knowing most...
> Actually I started to split upstream PR into multiple simple commits, so it's easier to review - maybe that'll speed things up? I'm o.k. with both options.
What is there on GO 1.21 that we should upgrade to ? Anyhow testing test tool isn't that straight forward yet. And the docker image need to update to make...