Froxlor
Froxlor copied to clipboard
froxlor
Opendkim support
Changed Dkim selector from dkim_ to dkim- added support for opendkim
Description
I manually hacked the files ages ago, here's a clean PR request. Code is running on my server with opendkim
Type of change
Please delete options that are not relevant.
- [x] New feature (non-breaking change which adds functionality)
- [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [x] This change requires a documentation update
How Has This Been Tested?
Updated my running froxlor with my edits.
Test Configuration:
- Distribution: centos 8
- Webserver: apache
- PHP: 7.2
- opendkim
Checklist:
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
This is a nice start, but if you intend to support a new service you should add the corresponding configuration-templates for every distribution to install and configure it
configuration templates are in Froxlor/lib/configfiles/ ? Is that correct ?
About lng files, they have to be filled too for the feature ? or base english is good enough in a first time ?
configuration templates are in Froxlor/lib/configfiles/ ? Is that correct ?
correct
About lng files, they have to be filled too for the feature ? or base english is good enough in a first time ?
at least the base/fallback language (english) has to be set
tbh there is no configuration template for dkim-filter and it's in the UI. I could add one for opendkim, i guess i'll put it in "others" as it needs to update postfix/main.cf but i can't make one for dkim-filter
tbh there is no configuration template for dkim-filter and it's in the UI.
Yes I know, that was some contributor way back and froxlor never 100% supported that (i personally dont know anyone using dkim-filter, most people use opendkim or amavis)
Alright. Added configuration templates for centos8 Other templates should be pretty similar though.
Added templates for the other systems. Except the two deprecated systems, because, well, deprecated :)
Can i do anything more ? I have some updates to make to the centos 8 templates, waiting for this PR to go thru before updating it. Also planning on adding rspamd support
I'm also currently reading and testing rspamd, question is whether opendkim is needed after all if rspamd includes the functionality
i've switched my mail servers to rspamd. It's pretty cool. Easiest integration is using the milter plugin in postfix.
I have opendkim and rspamd in a milter chain. Can always have opendkim support and rspamd support separately. For those who don't need spam filtering because they already have a mail gateway doing it. But need opendkim for Signing.
Can always have opendkim support and rspamd support separately. For those who don't need spam filtering because they already have a mail gateway doing it. But need opendkim for Signing.
agreed
besides, Rspamd supports opendkim signing_table and key_table . So one configuration could work with both ;) https://rspamd.com/doc/modules/dkim_signing.html#use-of-signing_table
I think I'm the only using dkim-filter :). I just wanted to thank @ZARk-be for his work, and hopefully fix the conflicts so this could be merged.
Thanks!
I'm not more using dkim-filter anymore (now I use the froxlor generate DKMI keys to feed rspamd) but I like to be an "+1" in counting those who are using froxlors DNS part and likes to see DKIM and more modern DNS-related stuff. From doop I read everytime "nearly nobody is usind DNS so there will be no work on DKMI, DMARC, ..." ;-(
I'm not more using dkim-filter anymore (now I use the froxlor generate DKMI keys to feed rspamd) but I like to be an "+1" in counting those who are using froxlors DNS part and likes to see DKIM and more modern DNS-related stuff. From doop I read everytime "nearly nobody is usind DNS so there will be no work on DKMI, DMARC, ..." ;-(
I never said there will be no work, I said due to very few users using the DNS feature at all, it has not very high priority. Currently testing out rspamd implementations because it would like to include this to the configuration templates generally
Sorry no. I give up with all the settings and templates, and getting side-tracked. Instead i made a simple php script to convert the generated dkim-filter config file to opendkim files. I just pasted it in a gist for other that would need this : https://gist.github.com/ZARk-be/633e7f76d58d9dc32e18350c4002612e
Thank you @ZARk-be that script will come in handy. After all these 9 years still using dkim-filter, after upgrading to Bookworm I've been getting error messages like this every once in a while
warning: milter inet:localhost:8891: can't read SMFIC_EOH reply packet header: Connection timed out
I figured that restarting the dkim-filter fixes the problem and after that emails get through, otherwise they are kept in the mail queue. What I've done for the moment is to restart the dkim-filter service every 10min using a cron entry.. I know is not a a solution, but it does the work until I get around and I install openkdim and run your script.
Thanks.
Any news about this important PR?
Sorry no. I gave up with all the settings and templates, and getting side-tracked. Instead i made a simple php script to convert the froxlor generated dkim-filter config file to opendkim files. Which i just run after froxlor updates.
I just pasted it in a gist for other that would need this : https://gist.github.com/ZARk-be/633e7f76d58d9dc32e18350c4002612e