Froxlor icon indicating copy to clipboard operation
Froxlor copied to clipboard

Feature Request: Support PGP encryption for backups

Open MatthiasLohr opened this issue 6 years ago • 13 comments

Froxlor should support PGP encryption of backups to increase security. That could be realized by adding a field pgp_public_key to the users basic data or within the backup dialog. After the backup archive was created successfully, and a pgp key is available, the archive should be encrypted, so only the owner of the according private key is able to read that backup.

That would be especially useful if it takes a long time to create the backup (e.g. overnight) and you do not want to have your plaintext backup stored that long.

What do you think about that?

Best regards Matthias

MatthiasLohr avatar Nov 20 '18 09:11 MatthiasLohr

Well, the "backup" feature is more like a "retreive all my data" for customers. If you want a REAL backup (with possibilities to restore, etc.) you should use something specially designed for that task. Froxlor will never integrate a full features backup functionality as there are so many (opensource) projects that do a great job at this already and which are focusing on that.

d00p avatar Nov 20 '18 09:11 d00p

Then let's rename it so "Support PGP encryption for 'retreive all my data'". Would ask for the same feature for that.

MatthiasLohr avatar Nov 20 '18 09:11 MatthiasLohr

Well, I'm not sure many people will use that but hey, why not. Are you interested in providing a PullRequest? :)

d00p avatar Nov 20 '18 09:11 d00p

Yes, why not. Give me some time for implementing this (I first have to (re)learn the structure of Froxlor). Thanks for reopening the feature request.

MatthiasLohr avatar Nov 20 '18 09:11 MatthiasLohr

@d00p, I have now some code prepared (currently in testing stage). Does a pull request has a change to get merged (regarding the 0.10 rewrite) for 0.9.x?

MatthiasLohr avatar Nov 27 '18 11:11 MatthiasLohr

No new features in 0.9.x

d00p avatar Nov 27 '18 11:11 d00p

Then I will wait for 0.10 for providing a pull request.

MatthiasLohr avatar Nov 27 '18 11:11 MatthiasLohr

Why wait? 0.10.0 is current MASTER

d00p avatar Nov 27 '18 11:11 d00p

Because it's not released yet. I want to have a stable code base for developing this feature. Otherwise, I have to rearrange the pull request after possible major changes in your code - and I don't now how "finalized" the code is right now ("Like every other version before: when its done"), so I will wait.

MatthiasLohr avatar Nov 27 '18 11:11 MatthiasLohr

As said, there will be no new features added to 0.9.x as the next major release will be 0.10.0

d00p avatar Nov 27 '18 11:11 d00p

So, 0.10.x is out....anything new here? :)

d00p avatar Nov 09 '19 10:11 d00p

Not yet, didn't recognize that 0.10.x is released. When I find the time, I will start with implementing that.

MatthiasLohr avatar Nov 09 '19 10:11 MatthiasLohr

I think I'm interested in implementing this in 2.x, but I think it will be a post-release feature since the current 2.0 todo is relatively full.

envoyr avatar May 31 '22 09:05 envoyr

added in 5731f5f

envoyr avatar May 21 '23 18:05 envoyr