Froxlor icon indicating copy to clipboard operation
Froxlor copied to clipboard

Start of switchable DKIM Implementation

Open d00p opened this issue 3 years ago • 1 comments

  • Rspamd dkim_selector.map dkim_path.map
  • Stores dkim_selector in domain table
  • Works without enabled DNS Server
  • based on feature/rspamd by cs8898

Description

Please include a summary of the change and which issue is fixed if any. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [ ] Test A
  • [ ] Test B

Test Configuration:

  • Distribution:
  • Webserver:
  • PHP:
  • etc.etc.:

Checklist:

  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes

d00p avatar Jan 24 '22 18:01 d00p

Hab es mal bei mir getestet. Hilft mir schonmal weiter. danke

Für andere die das geg. auch benötigen:

Download des Patches: wget https://patch-diff.githubusercontent.com/raw/Froxlor/Froxlor/pull/1007.patch

Fehlende Files anlegen damit der Patch durchläuft: mkdir -p lib/Froxlor/Cron/Dkim/ touch lib/Froxlor/Cron/Dkim/DkimCron.php touch lib/Froxlor/Cron/Dkim/DkimFilter.php touch lib/Froxlor/Cron/Dkim/Rspamd.php mkdir -p lib/Froxlor/UnitTest touch lib/Froxlor/UnitTest/FroxlorTestCase.php mkdir tests/Dkim/ touch tests/Dkim/DkimCronTest.php touch tests/Froxlor/FileDirTest.php mkdir lib/Froxlor/Dkim/ touch lib/Froxlor/Dkim/Dkim.php

Patch testen: patch --dry-run -p1 <1007.patch Patch anwenden: patch -p1 <1007.patch

Fehlendes Feld anlegen in der DB ALTER TABLE panel_domains ADD dkim_selector varchar(128) AFTER dkim_id;

drexlma avatar Jun 16 '22 13:06 drexlma

@eis-os is this still being worked on?

d00p avatar Nov 05 '22 08:11 d00p

I did have a v2 branch, but with the new major version it got quite useless.

https://github.com/Froxlor/Froxlor/commit/5420a99828d7b3c5f690be93e254cfc343daf02a

So, yes, simple close this PR, it won't go any forward.

eis-os avatar Nov 06 '22 12:11 eis-os