Carlo Revelli

Results 77 comments of Carlo Revelli

actually it looks like the travis build failed so the new build hasn't been pushed to composer yet..., should be fixed today once @kroitor comes back online

yep it would definitely get merged if the code was compact :) We also need to have options to support the different types of ecdsa and the map them from...

I am getting banned from cloudflare for having the default user agent in this library. Is it possible to remove that header from here -https://github.com/reactphp/http/blob/b3ff9c8cf63c06b5b734a9ffe9e0e5586049e541/src/Client/RequestData.php#L32 and make it optional. I...

> How about removing the default User Agent from here: > > https://github.com/reactphp/http/blob/b5a66a4faa77f8e8ab0094566501b9f40cb5079e/src/Client/RequestData.php#L32 > > > and re-adding it in the Browser constructor via your new `withHeader()` function? Then it...

this code returns a string and not a number for the orderbook objects. let's make sure we fully test the precise code edits...

to add to this you can install gmp with https://www.php.net/manual/en/gmp.installation.php ``` sudo apt install php-gmp ```

also should slightly reduce memory consumption by referencing the same objects in the this.markets and this.markets_by_id

@wunderb1t it's working for me, what version of ccxt are you using? ``` { info: { id: '589729003249292', symbol: 'btcusdt', 'account-id': '43108158', 'client-order-id': 'AA03022abce87ef7f7-f1b5-4fcf-a2ad-201bb60d33c6', amount: '0.000100000000000000', price: '0.0', 'created-at': '1658440131091',...

i think that I want to redo the orderbook limiting code so that we don't emulate the limiting and only send it to an exchange as a parameter