Frost Ming
Frost Ming
> I looked into `C:\Users\eight04\AppData\Roaming` and there is no `pdm` folder. Does `install-pdm` remove the directory on failure? Nope, I suspect the venv is not created successfully. Can you help...
I am not going to accept this patch because I don't think this requirement has been carefully considered. There may be many different situations here, each corresponding to a user...
> To execute python correctly, we have to call its real path: > > ```python > subprocess.run([p.resolve(), "--version"]) # 3.12.4 > ``` Great, thanks for the investigation. So does it...
Your pre-commit hook is indeed more convenient, but I have a small concern that this hook seems to assume that `mypy` has already been installed in the project. It also...
Can you explain more on how the extra info is used? Given this requirements ``` pydantic==1.8.2 pydantic[email]==1.8.2 ``` Note all other transitive dependencies are also exported but omitted. Why does...
> 2\. Parsing the `whl` `METADATA` file to get the `Requires-Dist` and generating the applicable dependencies for the target platform. But exported requirements should contain all transitive dependencies, so even...
I still can't get why it is necessary. Let's take `pydantic[email]==1.8.2` as an example. Here is what `pdm export --no-hashes` outputs: ``` dnspython==2.4.2 pydantic[email] email-validator==2.1.0.post1 # from pydantic[email] idna==3.6 #...
This is too complex IMO. What you need is to revert all side-effect caused by `Project.resolve_interpreter()`, this is enough: ```python project._saved_python = None project._python = None ```
I agree that `resolve_interpreter` has too many side-effects and it's bad. We need a side-effect-free version of it, no writing files, no saving states, no virtualenv creation. but `in_import` isn't...
I am closing this PR, if you have further fixes feel free to open a new one.