yarnhook icon indicating copy to clipboard operation
yarnhook copied to clipboard

Consider dropping execa

Open frontsideair opened this issue 5 years ago • 2 comments

The project can have zero dependencies without execa, which has listed their benefits but maybe we don't need any of them? Test extensively.

frontsideair avatar Oct 29 '20 13:10 frontsideair

Just my 2 cents, probably better to just keep execa, I don't think having zero deps is all that interesting. Claiming only 1 dependency is pretty good too

On Thu, Oct 29, 2020, 8:35 AM Fatih Altinok [email protected] wrote:

The project can have zero dependencies without execa, which has listed their benefits https://github.com/sindresorhus/execa#why but maybe we don't need any of them? Test extensively.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/frontsideair/yarnhook/issues/51, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEDZKDYODR4773TD775W2DSNFVTXANCNFSM4TDXWUXQ .

devinrhode2 avatar Oct 29 '20 16:10 devinrhode2

Agreed that it's not an urgency. But I gave the benefits a quick read and it doesn't seem like we would be missing out on anything if we dropped execa or cross-spawn. I need to do an investigation to be sure as I wouldn't want to leave Windows users behind for any reason.

frontsideair avatar Oct 31 '20 12:10 frontsideair