react-sortable-tree-theme-full-node-drag icon indicating copy to clipboard operation
react-sortable-tree-theme-full-node-drag copied to clipboard

Published 20 hours ago • verified publisher icon frontend-collective

fix issue with rowDirection missing

Open darewreck54 opened this issue 5 years ago • 9 comments

  • Fix issue with rowDirection missing
  • updated react-sortable-tree to 2.2.0

Followed https://github.com/frontend-collective/react-sortable-tree-theme-file-explorer/pull/18/files https://github.com/frontend-collective/react-sortable-tree-theme-file-explorer/issues/15

Address issue: https://github.com/frontend-collective/react-sortable-tree-theme-full-node-drag/issues/6

darewreck54 avatar Jun 17 '19 02:06 darewreck54

@fritz-c Can you merge this PR into the main repo? I don't have permission to do it. And doesn't seem I can tag you to review this code.

Thanks!

darewreck54 avatar Jun 17 '19 02:06 darewreck54

Agree.. can we get this PR merged?

rlyle avatar Jun 19 '19 19:06 rlyle

@fritz-c Tagging you again.

darewreck54 avatar Jul 03 '19 12:07 darewreck54

@lifejuggler

darewreck54 avatar Jul 04 '19 18:07 darewreck54

Sorry I think I had asked but I now realize I don't have permission to review this. @wuweiweiwu would you be able to review?

lifejuggler avatar Jul 06 '19 02:07 lifejuggler

@lifejuggler thanks for trying....maybe a lost cause

darewreck54 avatar Jul 10 '19 05:07 darewreck54

@lifejuggler Can we just fork this repo to a repo where people have permission. Then replace the reference theme to the new repo so people can actually add fixes?

darewreck54 avatar Jul 31 '19 23:07 darewreck54

@darewreck54, thats a pretty good idea.. might as well call it theme-x-v2 or something and just add a new link instead of replacing the old one... I'll try to ask the owners to see if they can either merge this in or let me get access

lifejuggler avatar Jul 31 '19 23:07 lifejuggler

I am still getting the issue of rowDirection missing

DinMon avatar Aug 25 '20 00:08 DinMon